Bug 5932 - subroutine itemdata to be replaced in C4::Serials
Summary: subroutine itemdata to be replaced in C4::Serials
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 14:59 UTC by Colin Campbell
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.39 KB, patch)
2011-03-22 15:07 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2011-03-22 14:59:28 UTC
C4::Serials has an internal subroutine itemdata which retrieves all the data from items and biblioitems for a given barcode. Its only use is as a boolean check of whether the given barcode has been assigned or not. The current functionality clearly does not belong in C4::Serials.

Replace with a with a lighter function which only returns the info we are interested in, pending clean up of the Item interface. Should make code more maintainable/redeable and possibly save a couple of cpu cycles.
Comment 1 Colin Campbell 2011-03-22 15:07:18 UTC
Created attachment 3398 [details] [review]
Proposed patch
Comment 2 Julian Maurice 2011-03-24 09:49:58 UTC
I don't see big performance improvement, but it works.
Signed off.
Comment 3 Chris Cormack 2011-03-27 08:21:19 UTC
Patch pushed, please test