Bug 5967 - OPAC performance enhancement, only deal with subscrition data, if the record has a subscription attached
Summary: OPAC performance enhancement, only deal with subscrition data, if the record ...
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5584
  Show dependency tree / graph
 
Reported: 2011-03-28 02:21 UTC by Chris Cormack
Modified: 2012-10-26 00:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-28 02:21:44 UTC 

    


    


      



        
          Comment 1
        

        
          Chris Cormack

        

        
        

        
          2011-03-28 02:29:54 UTC
        

      






I think there is a bug in this.

+if ($dat->{'serial'}){
+    my $subscriptionsnumber = CountSubscriptionFromBiblionumber($biblionumber);
+    my @subscriptions       = GetSubscriptions( $dat->{title}, $dat->{issn}, $biblionumber );
+
+    my @subs;
+    $dat->{'serial'}=1 if $subscriptionsnumber;

    


    


      



        
          Comment 2
        

        
          Julian Maurice

        

        
        

        
          2011-03-30 10:38:20 UTC
        

      






Where is the patch?

    


    


      



        
          Comment 3
        

        
          Paul Poulain

        

        
        

        
          2011-05-06 16:17:37 UTC
        

      






Hi Chris,

I can't find the patch. Do you have it ? Otherwise, i'll close the bug. Anyway, i'm not 100% sure this patch is a good idea: it relies on the fact that biblio.serials field is set when there is a subscription. Is it what you've in MARC21 ? (we have it in UNIMARC) Seems your 942$s field is mapped here so, maybe i fear something without reason...