Bug 5972 - DisplayClearScreenButton preference introduces invalid markup
Summary: DisplayClearScreenButton preference introduces invalid markup
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 15:07 UTC by Owen Leonard
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed fix (1.37 KB, patch)
2011-03-28 15:11 UTC, Owen Leonard 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-03-28 15:07:54 UTC 
<input type=button value="Clear Screen" onClick="window.location = '/cgi-bin/koha/circ/circulation.pl'">

 - all attributes should be quoted
 - all attributes should be in lower case
Comment 1 Owen Leonard 2011-03-28 15:08:53 UTC 
- input tags should be self-closing: < ... />
Comment 2 Owen Leonard 2011-03-28 15:11:42 UTC 
Created attachment 3467 [details] [review]
Proposed fix
Comment 3 Chris Cormack 2011-03-30 07:03:16 UTC 
Patch pushed, please test
Comment 4 MJ Ray (software.coop) 2011-04-07 10:50:48 UTC 
This bug is mentioned in:
Fix for Bug 5972 - DisplayClearScreenButton	preference introduces invalid markup http://lists.koha-community.org/pipermail/koha-patches/2011-March/014282.html
Fix for Bug 5972 - DisplayClearScreenButton	preference introduces invalid markup http://lists.koha-community.org/pipermail/koha-patches/2011-March/014273.html