Without any consideration of the System preference SearchMyLibraryFirst, When patron is logged in, the library set is set to the patron's library. This is not the expected behaviour and is implied by GetBranchesLoop and the fact that users library is selected by default. Overwriting this behaviour in opac-search.pl when user not logged in or SearchMyLibraryFirst not set i.e. mybranch not set
Created attachment 3478 [details] [review] Proposed Patch
This may be fixed by patch for bug 5852. Regardless, I don't think that manually unsetting the selection is the way to do it. Better to correct GetBranchesLoop.
For me, this issue has been fixed by patch for bug 5852 (for bug 5390 , in fact). Although it works well with the proposed patch applied, it also works well without it. As patch for bug 5390 has already been applied to master, I mark this bug as duplicate for 5390, and thus, resolved. *** This bug has been marked as a duplicate of bug 5390 ***
This bug is mentioned in: Bug 5977 : MT3617 : opac search advanced Library set to my library http://lists.koha-community.org/pipermail/koha-patches/2011-March/014293.html