Bug 6014 - Log viewer needs permissions
Summary: Log viewer needs permissions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Transaction logs (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) major
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5992
  Show dependency tree / graph
 
Reported: 2011-03-30 22:11 UTC by Chris Cormack
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed Patch (12.78 KB, patch)
2011-03-30 22:19 UTC, Chris Cormack 		Details | Diff | Splinter Review
A screenshot illustrating the problem (63.77 KB, image/png)
2011-06-06 16:39 UTC, Janusz Kaczmarek 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-30 22:11:12 UTC 

    


    


      



        
          Comment 1
        

        
          Chris Cormack

        

        
        

        
          2011-03-30 22:19:48 UTC
        

      






Created attachment 3557 [details] [review]
Proposed Patch

    


    


      



        
          Comment 2
        

        
          Frederic Durand

        

        
        

        
          2011-04-06 15:30:26 UTC
        

      






It's ok, without reports permission no way to see the modification logs from the circulation menu.

    


    


      



        
          Comment 3
        

        
          Chris Cormack

        

        
        

        
          2011-04-07 01:19:13 UTC
        

      






Pushed, please test

    


    


      



        
          Comment 4
        

        
          MJ Ray (software.coop)

        

        
        

        
          2011-04-08 06:29:57 UTC
        

      






This bug is mentioned in:
Bug 6014 : MT3138 Adding some permission	management to viewlog http://lists.koha-community.org/pipermail/koha-patches/2011-March/014382.html

    


    


      



        
          Comment 5
        

        
          Janusz Kaczmarek

        

        
        

        
          2011-06-06 16:38:17 UTC
        

      






I believe this patch adds some enhancements (although since there is no detailed description I was unable to get the exact point), BUT it also introduces some problems.  One is mentioned in Bug 6460.  

Another one is that apparently because of the changes made to vielog.tmpl (and, consequently, to viewlog.tt), the log generated from Tools --> Log viewer dialog (if it is generated at all--cf. Bug 6460), appears twice.  Cf. attached screeshot from 3.2.9 (the same happens in 3.4.1).

Because I am not aware what was the purpose for duplicating the whole part of vielog.tmpl which generates the log table I will not dare to touch it.  So, please, could you review you patch...?

Thank you in advance.

Janusz

    


    


      



        
          Comment 6
        

        
          Janusz Kaczmarek

        

        
        

        
          2011-06-06 16:39:00 UTC
        

      






Created attachment 4383 [details]
A screenshot illustrating the problem

    


    


      



        
          Comment 7
        

        
          Katrin Fischer

        

        
        

        
          2012-03-11 08:05:13 UTC
        

      






Logs are no longer duplicated. Marking this bug resolved.