We have found that the shelving cart feature added in Bug 3481 can wipe the permanent shelving location in a certain combination of circumstances, particularly if the In Processing part of the feature is not used. Patch is coming.
Created attachment 3602 [details] [review] patch file for Bug 6034 To test, with InProcessingToShelvingCart off, NewItemsDefaultLocation blank, and ReturnToShelvingCart on, create a new item. Check the contents of the location and permanent_location fields in its item record -- the same value should be in both. Then run the item through checkin, and look at those fields again. The location field should now be set to CART while permanent_location should still have the original value. After the cart_to_shelf cron job runs with the proper timing, check the item record again. Both location and permanent_location should again be identical.
This should be included in 3.2.x as well as 3.4.
Created attachment 4490 [details] [review] [SIGNED OFF] Bug 6034 - Shelving cart feature can wipe permanent shelving location in certain circumstances Bugfix for problems when shelving cart used without In Processing settings To test, with InProcessingToShelvingCart off, NewItemsDefaultLocation blank, and ReturnToShelvingCart on, create a new item. Check the contents of the location and permanent_location fields in its item record -- the same value should be in both. Then run the item through checkin, and look at those fields again. The location field should now be set to CART while permanent_location should still have the original value. After the cart_to_shelf cron job runs with the proper timing, check the item record again. Both location and permanent_location should again be identical.
QA comment: * the 1st patch attached is not obsolete, the [SIGNED OFF] one is correct * the patch still applies * the code looks good, and is small * I never have used this feature, I can't confirm the behaviour was wrong and was right. Liz has signed off, I trust her for this I will mark "passed QA" based on those considerations. Chris, accept or object, I won't complain if you ask for Ian opinion
Tested as per Liz's test script (Thanks liz) works as described, pushed please test
Released in 3.4.0