Bug 6057 - Improve finding next stock number
Summary: Improve finding next stock number
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 11:57 UTC by Alex Arnaud
Modified: 2013-12-05 20:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch for: Improve finding next stock number (1.19 KB, patch)
2011-04-05 12:11 UTC, Alex Arnaud
Details | Diff | Splinter Review
proposed fix signed-off (1.24 KB, patch)
2011-07-22 10:42 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Arnaud 2011-04-05 11:57:21 UTC

    
Comment 1 Alex Arnaud 2011-04-05 12:11:44 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2011-04-05 13:17:34 UTC
Must return 1 if mysql return NULL.
With a IFNULL(..., 1).
Field 'inventory number' must be inactive ?
Comment 3 Paul Poulain 2011-07-22 10:42:24 UTC
Created attachment 4717 [details] [review]
proposed fix signed-off

Julian : if the field is NULL, then it means the plugin is not activated (it's useless), so your comment is irrelevant.

I've tested, it works, signing-off
Comment 4 Chris Cormack 2011-08-01 00:09:10 UTC
Simple change, pushed
Comment 5 Jared Camins-Esakov 2012-12-31 00:29:21 UTC
There have been no further reports of problems so I am marking this bug resolved.