On the list for managing uncertain prices there is a column for quantity that can be edited. When creating your items on order the possibility to create items there does not make sense. When changing the quantity the uncertain price will be unset and the quantity changes to your entered number. But no additional items will be created and there is no warning about that.
This appears to still be valid in master as of 3.12 beta1.
Not sure to know what is the expected behavior here.
Hi Jonathan, I think it should not be possible to edit the quantity when items are created 'on order' - because it won't create the items.
Created attachment 37560 [details] [review] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed.
Created attachment 38149 [details] [review] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 38153 [details] [review] [PASSED QA] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.7