Bug 6066 - itemtype when ordering and item-level_itype=no
Summary: itemtype when ordering and item-level_itype=no
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 13:15 UTC by Paul Poulain
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (3.70 KB, patch)
2011-04-05 13:16 UTC, Paul Poulain
Details | Diff | Splinter Review
proposed patch for T::TT (3.61 KB, patch)
2011-05-23 11:47 UTC, Paul Poulain
Details | Diff | Splinter Review
rebased patch (3.59 KB, patch)
2011-06-29 18:45 UTC, Paul Poulain
Details | Diff | Splinter Review
BZ6066 let's the librarian choose the itemtype when ordering (3.64 KB, patch)
2011-07-04 23:10 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-04-05 13:15:07 UTC
(MT5189) let's the librarian choose the itemtype when ordering
    
For libraries with item-level_itype, the itemtype is in the item.
For others, it's in the biblio and should be added with the title/author when it's ordered
    
This patch adds the list when applicable,and build the biblio record accordingly
Comment 1 Paul Poulain 2011-04-05 13:16:17 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-04-05 13:24:28 UTC
Tested with MARC21 database on current HEAD.

The itype shows up on the title level and can be set. 
The itype is still showing up on item level too - if not set you get a perl error message when saving the order.
Comment 3 Paul Poulain 2011-05-23 11:47:02 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2011-05-23 20:50:43 UTC
Tried to apply 2nd patch: proposed patch for T::TT

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: MT5189 let's the librarian choose the itemtype when ordering
fatal: sha1 information is lacking or useless (acqui/neworderempty.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 MT5189 let's the librarian choose the itemtype when ordering
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
Comment 5 Paul Poulain 2011-06-29 18:45:56 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2011-07-04 23:10:54 UTC Comment hidden (obsolete)
Comment 7 Ian Walls 2011-07-08 19:31:18 UTC
This patch does correctly add an item type dropdown for acquisitions from an empty record when the system is configured to use biblio-level item types.  Marking this as Passed QA
Comment 8 Chris Cormack 2011-07-10 08:31:19 UTC
Pushed, please test
Comment 9 Katrin Fischer 2011-07-17 11:25:31 UTC
I found no problems for AcqCreateItem set to create item in cataloging or on receive.

For AcqCreateItem on order:

Create a new order from empty or existing record. 
Fill in the itemtype in the section for the bilbiographic record, for example use an itemtype 'on order'.
Leave the item fields empty, don't enter data.
Fill out fund and price.
Save.

Software error:

mismatched tag at line 7, column 2, byte 273 at /usr/lib/perl5/XML/Parser.pm line 187
Comment 10 Paul Poulain 2011-07-18 10:41:47 UTC
katrin, it's typically a framework (ACQ ?) that is wrong. I think it's not related to this bug
Comment 11 Katrin Fischer 2011-07-18 11:08:00 UTC
Paul, I tried several things to make the framework work, it works for item level itypes. If you can tell me how to make it work without getting an error message - which field(s) needs to be mandatory or how the framework needs to be configured, this could be added to documentation.
A perl error message is never helpful and only scaring librarians ;)
Comment 12 Paul Poulain 2011-07-29 09:53:30 UTC
Has someone else this problem ? (i'll try to reproduce it on a marc21, on unimarc, i don't have a problem). Katrin, did you test on a fresh marc21 setup or a specific DB ?
Comment 13 Katrin Fischer 2011-07-29 10:02:07 UTC
I drop/recreate my database very often. It was almost a fresh MARC21 install and different installation and database than the one I had in Marseille where I also saw this problem.
I think it's perhaps a configuration difference. Have you set AcqCreateItem to 'on order'?
Comment 14 Chris Nighswonger 2011-09-07 18:31:21 UTC
Bumping to master.
Comment 15 Paul Poulain 2012-02-15 15:59:57 UTC
Katrin, any chance to reproduce the problem or could we close this bug ?
Comment 16 Katrin Fischer 2012-02-22 05:47:28 UTC
I think the problem I had was related to another bug with item creation in acquisitions. I retested the feature on current master and had no problems on saving the item. Closing this bug as resolved.