(MT5189) let's the librarian choose the itemtype when ordering For libraries with item-level_itype, the itemtype is in the item. For others, it's in the biblio and should be added with the title/author when it's ordered This patch adds the list when applicable,and build the biblio record accordingly
Created attachment 3685 [details] [review] proposed patch
Tested with MARC21 database on current HEAD. The itype shows up on the title level and can be set. The itype is still showing up on item level too - if not set you get a perl error message when saving the order.
Created attachment 4226 [details] [review] proposed patch for T::TT Patch adapted for T::T Note that I couldn't reproduce the problem Katrin noticed.
Tried to apply 2nd patch: proposed patch for T::TT Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: MT5189 let's the librarian choose the itemtype when ordering fatal: sha1 information is lacking or useless (acqui/neworderempty.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 MT5189 let's the librarian choose the itemtype when ordering When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip".
Created attachment 4531 [details] [review] rebased patch
Created attachment 4556 [details] [review] BZ6066 let's the librarian choose the itemtype when ordering For libraries with item-level_itype, the itemtype is in the item. For others, it's in the biblio and should be added with the title/author when it's ordered This patch adds the list when applicable,and build the biblio record accordingly (BibLibre MT5189) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This patch does correctly add an item type dropdown for acquisitions from an empty record when the system is configured to use biblio-level item types. Marking this as Passed QA
Pushed, please test
I found no problems for AcqCreateItem set to create item in cataloging or on receive. For AcqCreateItem on order: Create a new order from empty or existing record. Fill in the itemtype in the section for the bilbiographic record, for example use an itemtype 'on order'. Leave the item fields empty, don't enter data. Fill out fund and price. Save. Software error: mismatched tag at line 7, column 2, byte 273 at /usr/lib/perl5/XML/Parser.pm line 187
katrin, it's typically a framework (ACQ ?) that is wrong. I think it's not related to this bug
Paul, I tried several things to make the framework work, it works for item level itypes. If you can tell me how to make it work without getting an error message - which field(s) needs to be mandatory or how the framework needs to be configured, this could be added to documentation. A perl error message is never helpful and only scaring librarians ;)
Has someone else this problem ? (i'll try to reproduce it on a marc21, on unimarc, i don't have a problem). Katrin, did you test on a fresh marc21 setup or a specific DB ?
I drop/recreate my database very often. It was almost a fresh MARC21 install and different installation and database than the one I had in Marseille where I also saw this problem. I think it's perhaps a configuration difference. Have you set AcqCreateItem to 'on order'?
Bumping to master.
Katrin, any chance to reproduce the problem or could we close this bug ?
I think the problem I had was related to another bug with item creation in acquisitions. I retested the feature on current master and had no problems on saving the item. Closing this bug as resolved.