Bug 6069 - Multiple level budget list on suggestions
Summary: Multiple level budget list on suggestions
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Christophe Croullebois
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 34483
  Show dependency treegraph
 
Reported: 2011-04-05 14:23 UTC by Paul Poulain
Modified: 2023-08-04 20:22 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (9.12 KB, patch)
2011-04-05 14:25 UTC, Paul Poulain
Details | Diff | Splinter Review
proposed patch for T::TT (8.94 KB, patch)
2011-08-01 15:23 UTC, Paul Poulain
Details | Diff | Splinter Review
proposed patch (taking care of Jonathan comment) (8.94 KB, patch)
2011-08-05 09:41 UTC, Paul Poulain
Details | Diff | Splinter Review
proposed patch (taking care of jonathan comment, wrong upload a few mn ago) (9.30 KB, patch)
2011-08-05 09:51 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-04-05 14:23:01 UTC
Librarians dealing with a suggestion have (and must have) access to all budgets.
For a large library/network, it means the list can be huge and impossible to deal with.
A possible solution would be to have multiple level lists : one for the top level, then one for the 2nd level, that appears when the 1st level is choosen, then one for the 3rd level (if applicable) when the 2nd level is choosen.
Comment 1 Paul Poulain 2011-04-05 14:25:43 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2011-04-05 14:47:33 UTC
Katrin notices that the behaviour is fine BUT :

* it would be great to have it on neworderempty too
* it's inconsistent with what has been done for 5953 : (the "show all" button) we can't have show all and multiple level
* the "show all button" is probably a bad idea = if a budget is inactive, it means we don't want to order on it anymore, so why would we have the opportunity to "show all" ?


Speaking of it some minutes, we agree that :
* the suggestion page MUST present all budgets and COULD present "my" budgets
* the new order page MUST present my budgets

It means an improvement could be done on both pages :
* suggestion : let the user click on "my budgets" to see only his budgets (in a single dropdown list) or "all budget" with this 3 level behaviour
* neworderempty : just keep "my" budget, but, if "I" have more than, for example 10 budgets, have a 3 level dropdown list.
Comment 3 Katrin Fischer 2011-04-05 14:56:44 UTC
The patch works great and I really like the new display because it makes the
different levels in budgets and funds visible instead of showing a flat list.

The problem I see is, that the display is limited to 3 levels only.
It is possible to create as many levels as you want - but only 3 levels can be
displayed with this option.

This means a library having created more then 3 levels (budget-fund-fund-...)
will not be able to choose a fund on the 4th level in suggestions, because it
will not be displayed.
Comment 4 Paul Poulain 2011-08-01 15:23:52 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2011-08-05 07:45:17 UTC
The proposed patch works well for me.

But i don't signed off : in suggestion/suggestion.pl we passed 2 times 'budgetsloop' to the tmpl :
$template->param( budgetsloop => $budgets);
$template->param( budgetsloop => $bud );

I think it's possible to delete the call to GetBudgets (l. 296).
Comment 6 Paul Poulain 2011-08-05 09:41:13 UTC Comment hidden (obsolete)
Comment 7 Paul Poulain 2011-08-05 09:51:05 UTC
Created attachment 4859 [details] [review]
proposed patch (taking care of jonathan comment, wrong upload a few mn ago)
Comment 8 Jonathan Druart 2011-08-05 10:02:44 UTC
Failed QA: 
If you edit the suggestion, select are not set with the good informations.
"Any" are always selected.
Comment 9 Marc Véron 2016-08-23 07:41:36 UTC
- patch does not apply
- ist this bug still valid?
Comment 10 Katrin Fischer 2023-08-04 20:22:11 UTC
I believe we should replace this with the funds list that has hierarchy levels etc as we have it on the receive screen. We should use that everywhere.