Lines issued from a staged file have a flag that can be set when the order has been added in a basket. It's set when a staged file is imported into the catalogue, it should be set also when a record is inserted through aquisition. * when a basket is imported in 1 clic, all lines in the import_batches are updated 'imported' * when everything from a import_batch has been imported into a basket, the import_batch is set 'imported' * don't display import_batches without anything to import
Created attachment 3716 [details] [review] proposed patch
It works for adding single titles from a staged record. The ordering in bulk from a staged records has not been pushed yet. Waiting for that do do more testing.
Created attachment 4218 [details] [review] Signed off patch
QA comment: won't do anything, as I'm author of this patch. But it fixes an annoying bug for libraries using an external source for their acquisition: the list is growing and growing. With this patch, each time everything has been imported from the reservoir to acquisition, the entry does not appear on the list anymore, it's much better.
QA comment: As Ian can't find time to mark passed QA this bug i do it myself, even if i'm author of the patch : * very light patch * signed-off by Katrin In case the description is not enough here is the test plan : * stage a file for import * retrieve one line or all the file in the acquisition module (basket.pl > Add order to basket from a staged file) * once it's done, do it again, the file and/or the line in the file still appear. It should not as it has been included in the catalogue when ordered
Paul, Thanks for the test plan. Works well, and the code logic is clean and consistent. Marking as Passed QA.
Pushed please test
This works in current master / 3.6.