Bug 6074 - setting import flags when staged file imported in aqbasket
Summary: setting import flags when staged file imported in aqbasket
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on: 5961
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-05 20:10 UTC by Paul Poulain
Modified: 2011-10-30 23:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (3.13 KB, patch)
2011-04-05 20:17 UTC, Paul Poulain
Details | Diff | Splinter Review
Signed off patch (3.49 KB, patch)
2011-05-22 19:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-04-05 20:10:19 UTC
Lines issued from a staged file have a flag that can be set when the order has been added in a basket. It's set when a staged file is imported into the catalogue, it should be set also when a record is inserted through aquisition.

* when a basket is imported in 1 clic, all lines in the import_batches are updated 'imported'
* when everything from a import_batch has been imported into a basket, the import_batch is set 'imported'
* don't display import_batches without anything to import
Comment 1 Paul Poulain 2011-04-05 20:17:08 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-04-06 08:33:25 UTC
It works for adding single titles from a staged record. The ordering in bulk from a staged records has not been pushed yet. Waiting for that do do more testing.
Comment 3 Katrin Fischer 2011-05-22 19:16:40 UTC
Created attachment 4218 [details] [review]
Signed off patch
Comment 4 Paul Poulain 2011-08-09 16:20:32 UTC
QA comment:
won't do anything, as I'm author of this patch. But it fixes an annoying bug for libraries using an external source for their acquisition: the list is growing and growing. With this patch, each time everything has been imported from the reservoir to acquisition, the entry does not appear on the list anymore, it's much better.
Comment 5 Paul Poulain 2011-10-06 12:41:36 UTC
QA comment:
As Ian can't find time to mark passed QA this bug i do it myself, even if i'm author of the patch :
* very light patch
* signed-off by Katrin

In case the description is not enough here is the test plan :
* stage a file for import
* retrieve one line or all the file in the acquisition module (basket.pl > Add order to basket from a staged file)
* once it's done, do it again, the file and/or the line in the file still appear. It should not as it has been included in the catalogue when ordered
Comment 6 Ian Walls 2011-10-06 17:05:34 UTC
Paul,


Thanks for the test plan.  Works well, and the code logic is clean and consistent.  Marking as Passed QA.
Comment 7 Chris Cormack 2011-10-06 21:29:51 UTC
Pushed please test
Comment 8 Katrin Fischer 2011-10-30 23:26:11 UTC
This works in current master / 3.6.