Bug 6084 - Missing translation markers in javascript alert messages
Summary: Missing translation markers in javascript alert messages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 12:00 UTC by Katrin Fischer
Modified: 2012-10-25 23:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Initial patch (21.31 KB, patch)
2011-04-06 17:54 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Follow up (6.99 KB, patch)
2011-04-06 17:55 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Signed off patch 1 (21.38 KB, patch)
2011-04-07 08:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Signed off patch 2 (7.09 KB, patch)
2011-04-07 08:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
[3.2.x] fix (29.02 KB, patch)
2011-04-18 11:10 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2011-04-06 12:00:32 UTC
It seems the translation tool is not picking up alert messages for translations when they are not properly formatted:

Bad:
alert("Your text will stay English forever!");

Good:
alert(_("Your text will be translatable!"));

A quick look at the code reveals a lot of translation problems in this area.
Comment 1 Tomás Cohen Arazi (tcohen) 2011-04-06 17:54:19 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2011-04-06 17:55:28 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-04-07 08:48:08 UTC
Tested this patches and signed off on them. 

One of the changes was made to a file in the js directory - it will not break anything, but will not work either. Tose files are not included into the translation process.

koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js

@Tomas: Don't forget to add the bug number to your commit messages! :)
Comment 4 Katrin Fischer 2011-04-07 08:49:07 UTC
Created attachment 3769 [details] [review]
Signed off patch 1
Comment 5 Katrin Fischer 2011-04-07 08:49:26 UTC
Created attachment 3770 [details] [review]
Signed off patch 2
Comment 6 Chris Cormack 2011-04-07 09:49:39 UTC
Pushed, please test
Comment 7 Tomás Cohen Arazi (tcohen) 2011-04-18 11:10:34 UTC
Created attachment 3936 [details] [review]
[3.2.x] fix