It seems the translation tool is not picking up alert messages for translations when they are not properly formatted: Bad: alert("Your text will stay English forever!"); Good: alert(_("Your text will be translatable!")); A quick look at the code reveals a lot of translation problems in this area.
Created attachment 3761 [details] [review] Initial patch I ommited commented lines and "if $debug" lines too.
Created attachment 3762 [details] [review] Follow up grep -R 'alert("' * was not enough. I needed grep -R "alert('" too!.
Tested this patches and signed off on them. One of the changes was made to a file in the js directory - it will not break anything, but will not work either. Tose files are not included into the translation process. koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js @Tomas: Don't forget to add the bug number to your commit messages! :)
Created attachment 3769 [details] [review] Signed off patch 1
Created attachment 3770 [details] [review] Signed off patch 2
Pushed, please test
Created attachment 3936 [details] [review] [3.2.x] fix