Bug 6086 - adding a dynamic filter to pending holds
Summary: adding a dynamic filter to pending holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: All All
: P3 minor
Assignee: Jonathan Druart
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 12:46 UTC by Alex Arnaud
Modified: 2013-12-05 20:01 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
The patch (47.03 KB, patch)
2011-04-06 13:08 UTC, Alex Arnaud
Details | Diff | Splinter Review
screenshot of the result (194.75 KB, image/png)
2011-08-10 09:03 UTC, Paul Poulain
Details
A new patch (20.73 KB, patch)
2012-03-02 15:23 UTC, Alex Arnaud
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6086 - adding a dynamic filter to pending holds (20.82 KB, patch)
2012-03-06 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6086 Followup Replace \t characters with 4 spaces (7.55 KB, patch)
2012-03-08 10:55 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Arnaud 2011-04-06 12:46:30 UTC
This patch uses a jquery lib to allow the user to filter the table by column with input textboxes,

two dropdown list boxes for easy filtering, a texbox for global search, and a clickable link to clear filters.

The order of the columns was changed to be more logical.
Comment 1 Alex Arnaud 2011-04-06 13:06:15 UTC
Updating to bug fix because when the list of pending is too long this is a nightmare to find a or some spécific(s) item(s).
Comment 2 Alex Arnaud 2011-04-06 13:08:43 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2011-04-08 01:00:59 UTC
Hmm whats with the changes to a jquery file?
Comment 4 Paul Poulain 2011-08-10 09:03:06 UTC Comment hidden (obsolete)
Comment 5 Ian Walls 2011-08-25 20:48:35 UTC
This patch no longer applies, and the new JQuery filter used needs some community feedback.  Marking as Failed QA until these issues are resolved.
Comment 6 Alex Arnaud 2011-09-02 10:17:35 UTC
i have to wait for a complet integration of datatable plugin before remake this patch.
Comment 7 Alex Arnaud 2012-03-02 15:23:02 UTC Comment hidden (obsolete)
Comment 8 Alex Arnaud 2012-03-02 15:27:35 UTC
Here is a new patch that take in account the new template system and the integration of datatables plugin.

I have deleted all code related to server-side pagination. Tested with 9k rows sent to the page: it's ok.
Comment 9 Owen Leonard 2012-03-06 17:42:50 UTC
Created attachment 8038 [details] [review]
[SIGNED-OFF] Bug 6086 - adding a dynamic filter to pending holds

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Jonathan Druart 2012-03-08 10:55:29 UTC
Created attachment 8080 [details] [review]
Bug 6086 Followup Replace \t characters with 4 spaces

Marked as Passed QA.

But Alex, could you set your editor to use spaces instead of tabulation ?
Comment 11 Paul Poulain 2012-03-08 17:21:58 UTC
Patch pushed BUT = can you note somewhere the [HTML4] coding guideline that says that "Hold To Pull" should be written "Hold to pull" (capital only on the 1st word). It was wrong before your patch, but you could have fixed it.