Created attachment 3746 [details] [review] Patch This patch adds a new script to purge message_queue table. All emails where subject and content are empty (NULL) are deleted. This script should be run before process_message_queue.pl
I wonder if we should have messages with empty message body and subject there in the first place? How does this happen?
Were getting empty messages being reported as well at multiple sites. The bug is surely that these are being added to the queue
Collin, we couldnot find how those empty messages got added to the message queue. Therefore, we did that workaround. If you find where the bug that creates those ghost message is, then, that will not be really usefull any longer. But will not harm much the system though.
The patch doesn't fix the problem, so setting status to assigned until someone send a patch that avoid empty mail to be added to message_queue (if bug still exists)
Created attachment 8085 [details] [review] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter
Hello, Need to config the sending of mails, so not as easy as I believed. We don't only have to generate an empty notice. (server Koha add to send really notices).
Created attachment 9996 [details] [review] [SIGNED-OFF] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: there is an unconditionnal warn + warn "Trying to add an empty message to the message queue"; that is thrown every time there is an empty letter. This should be issued only if you're in DEBUG mode
Created attachment 10151 [details] [review] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Typo: +kfpackage C4::Letters; How was this tested? :-) Please correct and set back to Needs signoff.
Created attachment 10377 [details] [review] Bug 6090: Do not enqueue empty messages The last patch was not re-tested as it only add 'if $debug' after a warn. This patch fix the 'kfpackage' thing.
Created attachment 10378 [details] [review] Bug 6090: Do not enqueue empty messages Sorry, it was the wrong patch.
Created attachment 10381 [details] [review] [SIGNED-OFF] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Marking as Passed QA
Does this patch have to be pushed to stable?