Bug 6091 - Remove undeclared syspref OPACAdvSearchInputCount
Summary: Remove undeclared syspref OPACAdvSearchInputCount
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: 3.4
Hardware: All All
: P5 - low minor
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 14:03 UTC by Fridolin Somers
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed patch (1.72 KB, patch)
2011-04-06 14:08 UTC, Fridolin Somers 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2011-04-06 14:03:09 UTC 
In advanced search pages :
catalogue/search.pl
opac/opac-search.pl

A syspref "OPACAdvSearchInputCount" is called to get number of input boxes to display. If syspref is false, there will be 3.

This syspref is not declared in administration, .pref files, nor in database installers.

I propose to simply remove this syspref call, input boxes number doesn't need a syspref since user can create new ones.

Regards,
Comment 1 Fridolin Somers 2011-04-06 14:08:08 UTC 
Created attachment 3747 [details] [review]
Proposed patch
Comment 2 Ian Walls 2011-05-25 15:41:25 UTC 
Covers all instances of this undefined system preference being called.  Better to remove these stubs, in my opinion, then add yet another system preference for what may not be a terribly desirable feature.

Marking as Passed QA.
Comment 3 Chris Cormack 2011-05-28 07:07:02 UTC 
Pushed please test