Bug 6106 - add item not respecting framework in acq
Summary: add item not respecting framework in acq
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
: 5955 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-07 08:54 UTC by Paul Poulain
Modified: 2011-11-20 23:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (4.06 KB, patch)
2011-04-07 08:55 UTC, Paul Poulain
Details | Diff | Splinter Review
Signed off patch (4.17 KB, patch)
2011-04-07 15:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-04-07 08:54:10 UTC
The PrepareItemrecordDisplay sub builds an item framework for later use in ACQ
Some cases were missing : item subfield connected to a plugin, hidden subfield, long size subfield.

Steps to reproduce : 
* attach a plugin to the ACQ framework, 
* AcqCreateItems is set to "ordering"
* the "..." does not appear on the right of the subfield when ordering
Comment 1 Paul Poulain 2011-04-07 08:55:51 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-04-07 10:08:42 UTC
The ... appear now, but they don't seem to work. I was testing 952$d date acquired. The current date was not added into the field.
Comment 3 Paul Poulain 2011-04-07 14:48:06 UTC
yikes !
This did not work because the plugin dateaccessioned is wrong, not because of this patch !
dateaccessioned relies on a javascript sub (set_to_today) that is defined in additem.pl !
For acquisition (and serials), the set_to_today is not defined.

I propose :
* to signoff this patch (katrin ?)
* to file another bug to move set_to_today to the plugin itself instead of additem
Comment 4 Katrin Fischer 2011-04-07 15:18:47 UTC
Created attachment 3811 [details] [review]
Signed off patch
Comment 5 Katrin Fischer 2011-04-07 15:19:26 UTC
This bug does not fix the plugin for dateaccessioned, but other plugins like barcode work. I will file a separate bug for the problem with dateaccessioned like Paul suggested.
Comment 6 Chris Cormack 2011-04-07 22:42:28 UTC
Pushed, please test
Comment 7 Katrin Fischer 2011-10-26 22:54:29 UTC
Tested:
- mandatory (item type)
- plugin (barcode with AutoBarcode activated)
- hiding several subfields

This works nicely. 

Date accessioned is still broken, see bug 6125.
Comment 8 Dobrica Pavlinusic 2011-11-20 23:42:31 UTC
*** Bug 5955 has been marked as a duplicate of this bug. ***