* the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting
Created attachment 3793 [details] [review] proposed patch
This patch working for sort grouping by month (march is getting before april). But not for day of week : 4-Friday is coming before 0-Monday.
Created attachment 4231 [details] [review] proposed patch (updated) For an unknown reason, it seems that monday (0) is moved AFTER other days (1-6) Fixed by adding +1 to weekday, to have it between 1 and 7
Saturday is coming before Wednesday in the column headings - but is right in the row headings. marking failed-qa
Created attachment 4567 [details] columns sorted wrong
Created attachment 4568 [details] rows sorting right
Created attachment 4669 [details] [review] proposed patch (updated again) nasty bug : the ordering was done on $column instead of $colfield. It was not visible in all cases, well spotted nicole !
Created attachment 4714 [details] [review] proposed patch (updated again) oups, i've uploaded the previous patch (without the fix). Uploading again. Please sign-off this one
diff between the previous one and the correct one: - $strsth2 .= " ORDER BY $column"; + $strsth2 .= " ORDER BY $colfield";
Created attachment 4851 [details] before patch I'm not sure I like the change this patch applies. The reports are in order by date just fine without the patch as shown in the attachment.
Created attachment 4852 [details] after patch after the patch it's showing the month number which is kind of distracting ... or am i missing what else this patch is doing?
Created attachment 4856 [details] wrong order screenshot Nicole, here is a screenshot with the problems (it's for weekdays).
Created attachment 4857 [details] wrong order screenshot Here is a wrong screenshot based on months Nicole: after investigating, it seems that the problem is visible only under certain circumstances. I think -but am not sure- if your datas alway have closedate ordered like basketid, then the result is correct, but it's by chance. My test DB contains : mysql> select closedate,basketno FROM aqbasket; +------------+----------+ | closedate | basketno | +------------+----------+ | 2011-06-20 | 1 | | 2010-07-20 | 2 | (basket 1 closed after basket 2)
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: BZ6115: Acquisition reports : date filter & sorting don't work Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging reports/acquisitions_stats.pl CONFLICT (content): Merge conflict in reports/acquisitions_stats.pl Failed to merge in the changes. Patch failed at 0001 BZ6115: Acquisition reports : date filter & sorting don't work When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort".
Created attachment 6930 [details] [review] BZ6115: Acquisition reports : date filter & sorting don't work * the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting * removed many commented warn & lines
Created attachment 6939 [details] [review] BZ6115: Acquisition reports : date filter & sorting don't work * the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting * removed many commented warn & lines Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Testing results 1/ Date filters work well 2/ Grouping by month/day of week/year produces a well sorted list
QA Comment: Looks good. Lots of warns removed. Has a solid signoff. patch_status++
This fix was included in the 3.6.x branch prior to 3.6.4.