Created attachment 3832 [details] [review] pro Set a timeout to z3950 servers that could have network problems occasionally Some of z3950 servers that our libraries must use, have network problems occasionally and when they are cataloguing and do a search over a z3950 server, if any of those Z selected have net problems, this search could have a delay of lot of time. If you dont want to execute updatedatabase.pl, simply execute this statement in you database ALTER TABLE `z3950servers` ADD `timeout` INT( 11 ) NOT NULL DEFAULT '0' AFTER `syntax`;
Created attachment 7615 [details] [review] Patch to apply in current master
Is the timeout setting in seconds? I would suggest adding that information to the Z39.50 server entry form. I recommend this: Timeout (Enter 0 for no timeout): [ ] seconds I would also like to see a message displayed on the search results screen about which servers were skipped because of a timeout. There's already error output for "actual" timeouts, so it's logical to include these "voluntary" timeouts too.
Created attachment 8414 [details] [review] Patch to apply in current master I've done some changes that Owen commented. Information in seconds when edit a z3950 server and inform if a server has timeout or connection failed errors.
Created attachment 8453 [details] [review] patch signed off
QA comment: * code very clean * add an interesting fallback in case of timeout * could not test a timeout case, but everything still works if the z3950 server is responsive enough. * the "timeout" error message is displayed in case of timeout (at least reading the code) passed QA
There have been no further reports of problems so I am marking this bug resolved.