* opac-topissue.pl = untranslatable string removed * moremember.pl: wrong " causing trouble to translator * authorities.pl missing _() in javascript
Little correction in bug description: * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript
Created attachment 3836 [details] [review] Patch
(In reply to comment #2) > Created attachment 3836 [details] [review] > Patch It doesn't apply anymore on HEAD.
Created attachment 10011 [details] [review] Bug 6141 - html glitches causing problems to translator * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice.
Created attachment 10035 [details] [review] Bug 6141 - html glitches causing problems to translator Simple fix, works... 'nuff said'
Signed off... but: Can anyone care to explain what the Importance being set to "PATCH-Sent (DO NOT USE)" actually means?
QA comment: as Martin said : Simple fix, works... 'nuff said' & passed QA (In reply to comment #6) > Signed off... but: Can anyone care to explain what the Importance being set > to "PATCH-Sent (DO NOT USE)" actually means? Our workflow used to use this "PATCH sent" to warn that the patch has been sent. Now, and since some months, it's in the status, so this priority should not be used anymore, and it's here only for some legacy entries. Feel free to update priority if you encounter a bug with this priority !
Patch does not apply to 3.8.x, please reformat for 3.8.x. (It contains changes to do with authorities, which haven't been pushed to 3.8.x namely <<<<<<< HEAD ======= $(document).ready(function() { yuiToolbar(); $("#addauthc,#action").empty(); }); // YUI Toolbar Functions function yuiToolbar() { etc)
Created attachment 10276 [details] [review] Bug 6141 - html glitches causing problems to translator - 3.8.x * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Chris, here you go. Does this need to go through so and qa? (In reply to comment #8) > Patch does not apply to 3.8.x, please reformat for 3.8.x. > > (It contains changes to do with authorities, which haven't been pushed to > 3.8.x namely > > <<<<<<< HEAD > ======= > $(document).ready(function() { > yuiToolbar(); > $("#addauthc,#action").empty(); > }); > // YUI Toolbar Functions > function yuiToolbar() { > > etc)
(In reply to comment #10) > Chris, here you go. Does this need to go through so and qa? > > Nope the original one was signed off, and this removes the conflicting code, I will test and push
Patch pushed to 3.8.x will be in 3.8.2