Created attachment 3833 [details] [review] Delete sub CanBookBeReserved
Created attachment 4594 [details] [review] followup(delete reference to sub on @EXPORT) : PATCH 1/2 (original) the first patch don't delete the reference to sub CanBookBeReserved on @EXPORT. I make a followup. This the first (original patch) of 2 files
Created attachment 4596 [details] [review] followup(delete reference to sub on @EXPORT) : PATCH 2/2 (followup) the first patch don't delete the reference to sub CanBookBeReserved on @EXPORT. I make a followup. This the second (followup patch) of 2 files
Which of these attachments is to be tested? Is the first one obsolete? Please squash the valid patches if there are more than one.
Created attachment 6027 [details] [review] Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT Author: Alex Arnaud <alex.arnaud@biblibre.com>, Stéphane Delaune <stephane.delaune@biblibre.com> Signed-off-by: MJ Ray <mjr@phonecoop.coop>
bug affected to Koha 3.6. Entries must be attached to rel_3_8 only when the patch is pushed here (and if it's an ENH)
You what? Surely this should be applied to master (3.8 now) and then pulled back to 3.6?
Can we confirm that C4/ILSDI/Services.pm correctly pulls in C4::Reserves::CanBookBeReserved? It's not in the explicit import on C4/ILSDI/Services.pm line 29 (the use statement for C4/Reserves).
Question seems unanswered. Changing status to reflect pending status.
Created attachment 6817 [details] [review] Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT Original-Author: Alex Arnaud <alex.arnaud@biblibre.com>, Stéphane Delaune <stephane.delaune@biblibre.com> Original-Signed-off-by: MJ Ray <mjr@phonecoop.coop> Correct use statement bug found by Ian Walls Author: MJ Ray <mjr@phonecoop.coop>
Created attachment 6859 [details] [review] Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT Original-Author: Alex Arnaud <alex.arnaud@biblibre.com>, Stéphane Delaune <stephane.delaune@biblibre.com> Original-Signed-off-by: MJ Ray <mjr@phonecoop.coop> Correct use statement bug found by Ian Walls Author: MJ Ray <mjr@phonecoop.coop> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Removes subroutine from C4/ILSDI/Utility.pm in favor of importing from C4/Reserves.pm Marking Passed QA
patch pushed, please test