Bug 6147 - Reading RSS feeds via Netvibes
Summary: Reading RSS feeds via Netvibes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Julian Maurice
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 13:53 UTC by Julian Maurice
Modified: 2012-10-25 23:09 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (9.27 KB, patch)
2011-04-08 13:55 UTC, Julian Maurice
Details | Diff | Splinter Review
Patch reformatted to work with template::toolkit (7.38 KB, patch)
2011-05-16 22:17 UTC, Chris Cormack
Details | Diff | Splinter Review
New patch (7.66 KB, patch)
2011-12-02 12:31 UTC, Julian Maurice
Details | Diff | Splinter Review
[Signed Off] Bug 6147 : Correcting invalid RSS (8.78 KB, patch)
2011-12-31 23:09 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2011-04-08 13:53:18 UTC
The SearchTerms must be URL encoded, and the item element "isbn" was undefined.
Comment 1 Julian Maurice 2011-04-08 13:55:37 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-05-16 22:17:33 UTC Comment hidden (obsolete)
Comment 3 Magnus Enger 2011-06-15 14:04:58 UTC
After applying the patch this URL: 

/cgi-bin/koha/opac-search.pl?idx=kw&q=lessig&count=50&sort_by=acqdate_dsc&format=rss2

gives me this error: 

Template process failed: file error - parse error - /home/magnus/kohahead/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt line 41: unexpected token (ELSE)
  [% ELSE %] at /home/magnus/kohahead/C4/Templates.pm line 119.

Marking as failed QA.
Comment 4 Magnus Enger 2011-06-15 14:08:21 UTC
PS: I tried adding an RSS feed from a search to Netvbies and did not get any errors in Netvbies...
Comment 5 Julian Maurice 2011-12-02 12:31:47 UTC Comment hidden (obsolete)
Comment 6 Arslan Farooq 2011-12-04 12:26:02 UTC
Without this patch, the rss feed does not validate in W3C Feed Validation Service:

see screenshot: http://goo.gl/T2f9o

----------------------------------------------------

Once this patch is applied, and viewing the feed:

/opac-search.pl?idx=kw&q=jane&count=50&sort_by=acqdate_dsc&format=rss2

I did the CTRL+U (view source) in my browser, copied the source, and validated by pasting the source in http://feed1.w3.org/ (Validate by Direct Input).

The result says: Congratulations! This is a valid RSS feed :)

But I just want to ask about these "Recommendations" before signing off. See screenshot: http://goo.gl/XCpFZ

Is it okay to sign off this bug? It sure is an improvement. The feed validates!
Comment 7 Katrin Fischer 2011-12-20 21:00:31 UTC
Julian or someone else more familiar with RSS - is the result Arslan got enough for sign-off?
Comment 8 Chris Cormack 2011-12-31 07:14:57 UTC
(In reply to comment #6)
> Without this patch, the rss feed does not validate in W3C Feed Validation
> Service:
> 
> see screenshot: http://goo.gl/T2f9o
> 
> ----------------------------------------------------
> 
> Once this patch is applied, and viewing the feed:
> 
> /opac-search.pl?idx=kw&q=jane&count=50&sort_by=acqdate_dsc&format=rss2
> 
> I did the CTRL+U (view source) in my browser, copied the source, and validated
> by pasting the source in http://feed1.w3.org/ (Validate by Direct Input).
> 
> The result says: Congratulations! This is a valid RSS feed :)
> 
> But I just want to ask about these "Recommendations" before signing off. See
> screenshot: http://goo.gl/XCpFZ
> 
> Is it okay to sign off this bug? It sure is an improvement. The feed validates!

Hi Arslan

Yes, I think its fine to sign off, but if someone wanted to do a followup to implement the recommendations that would be cool too

Chris
Comment 9 Liz Rea 2011-12-31 23:09:36 UTC
Created attachment 6997 [details] [review]
[Signed Off] Bug 6147 : Correcting invalid RSS

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Feed validates using http://feed1.w3.org/ with the following recommendations:

This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations.
line 12, column 149: Relative href value on self link: /cgi-bin/koha/opac-search.pl?idx=kw&q=some&sort_by=acqdate_dsc&format=rss2 [help]
... p;sort_by=acqdate_dsc&amp;format=rss2"/>
                                             ^
line 12, column 149: Self reference doesn't match document location [help]
... p;sort_by=acqdate_dsc&amp;format=rss2"/>
                                             ^
line 20, column 158: Unregistered link relationship: search (10 occurrences) [help]
... _by=&amp;format=opensearchdescription"/>
                                             ^
line 40, column 9: description should not contain relative URL references: /cgi-bin/koha/opac-reserve.pl?biblionumber=10 (10 occurrences) [help]
						]]></description>
         ^
line 22, column 5: Misplaced Item (9 occurrences) [help]
     <item>
Comment 10 Ian Walls 2012-01-05 13:00:55 UTC
Template only change to handle T:T conversion problem.  Marking as Passed QA.

Please leave this bug report open until the recommendations from the validator can be patched.  I recommend using this report to continue to track those improvements.
Comment 11 Paul Poulain 2012-01-06 13:38:29 UTC
patch pushed, please test
Comment 12 Julian Maurice 2012-01-12 10:05:37 UTC
Ok in master, marked as resolved.