The SearchTerms must be URL encoded, and the item element "isbn" was undefined.
Created attachment 3840 [details] [review] Patch
Created attachment 4131 [details] [review] Patch reformatted to work with template::toolkit
After applying the patch this URL: /cgi-bin/koha/opac-search.pl?idx=kw&q=lessig&count=50&sort_by=acqdate_dsc&format=rss2 gives me this error: Template process failed: file error - parse error - /home/magnus/kohahead/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt line 41: unexpected token (ELSE) [% ELSE %] at /home/magnus/kohahead/C4/Templates.pm line 119. Marking as failed QA.
PS: I tried adding an RSS feed from a search to Netvbies and did not get any errors in Netvbies...
Created attachment 6528 [details] [review] New patch Rebased patch against master, with fixes so rss feed pass the W3C validation http://feed1.w3.org/
Without this patch, the rss feed does not validate in W3C Feed Validation Service: see screenshot: http://goo.gl/T2f9o ---------------------------------------------------- Once this patch is applied, and viewing the feed: /opac-search.pl?idx=kw&q=jane&count=50&sort_by=acqdate_dsc&format=rss2 I did the CTRL+U (view source) in my browser, copied the source, and validated by pasting the source in http://feed1.w3.org/ (Validate by Direct Input). The result says: Congratulations! This is a valid RSS feed :) But I just want to ask about these "Recommendations" before signing off. See screenshot: http://goo.gl/XCpFZ Is it okay to sign off this bug? It sure is an improvement. The feed validates!
Julian or someone else more familiar with RSS - is the result Arslan got enough for sign-off?
(In reply to comment #6) > Without this patch, the rss feed does not validate in W3C Feed Validation > Service: > > see screenshot: http://goo.gl/T2f9o > > ---------------------------------------------------- > > Once this patch is applied, and viewing the feed: > > /opac-search.pl?idx=kw&q=jane&count=50&sort_by=acqdate_dsc&format=rss2 > > I did the CTRL+U (view source) in my browser, copied the source, and validated > by pasting the source in http://feed1.w3.org/ (Validate by Direct Input). > > The result says: Congratulations! This is a valid RSS feed :) > > But I just want to ask about these "Recommendations" before signing off. See > screenshot: http://goo.gl/XCpFZ > > Is it okay to sign off this bug? It sure is an improvement. The feed validates! Hi Arslan Yes, I think its fine to sign off, but if someone wanted to do a followup to implement the recommendations that would be cool too Chris
Created attachment 6997 [details] [review] [Signed Off] Bug 6147 : Correcting invalid RSS Signed-off-by: Liz Rea <wizzyrea@gmail.com> Feed validates using http://feed1.w3.org/ with the following recommendations: This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations. line 12, column 149: Relative href value on self link: /cgi-bin/koha/opac-search.pl?idx=kw&q=some&sort_by=acqdate_dsc&format=rss2 [help] ... p;sort_by=acqdate_dsc&format=rss2"/> ^ line 12, column 149: Self reference doesn't match document location [help] ... p;sort_by=acqdate_dsc&format=rss2"/> ^ line 20, column 158: Unregistered link relationship: search (10 occurrences) [help] ... _by=&format=opensearchdescription"/> ^ line 40, column 9: description should not contain relative URL references: /cgi-bin/koha/opac-reserve.pl?biblionumber=10 (10 occurrences) [help] ]]></description> ^ line 22, column 5: Misplaced Item (9 occurrences) [help] <item>
Template only change to handle T:T conversion problem. Marking as Passed QA. Please leave this bug report open until the recommendations from the validator can be patched. I recommend using this report to continue to track those improvements.
patch pushed, please test
Ok in master, marked as resolved.