Bug 6235 - "Saved" message in sysprefs never gets hidden on IE8
Summary: "Saved" message in sysprefs never gets hidden on IE8
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: rel_3_2
Hardware: All All
: P4 normal (vote)
Assignee: Frédérick Capovilla
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 14:25 UTC by Frédérick Capovilla
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Corrects a problem where the "Saved" message never disappeared on IE8. (1.28 KB, patch)
2011-04-21 14:25 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
Corrects the behavior of the humanmsg box on IE8 and IE7. (1.39 KB, patch)
2011-04-21 18:14 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
proposed patch (passed QA) (1.44 KB, patch)
2011-08-10 12:38 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2011-04-21 14:25:13 UTC Comment hidden (obsolete)
Comment 1 Owen Leonard 2011-04-21 15:14:48 UTC
I think the problem is not that the timeout is interpreted incorrectly, I think the problem is that IE doesn't recognize the event which should hide the message. The "infinity" behavior is desirable because it leaves the message on the screen indefinitely--unless some event occurs to trigger hiding it. A mouse movement seems to suffice in standards-compliant browsers. I think this is nice because if you switch away from your browser the message remains until you return.

I'd like to find out whether this behavior can be made to work in IE.
Comment 2 Owen Leonard 2011-04-21 15:35:28 UTC
http://code.google.com/p/humanmsg/issues/detail?id=1

The edit suggested in Comment 1 seems to fix the problem in Internet Explorer 8. The second suggestion causes errors for me. I'd love to see this change tested in IE7 if anyone has it.
Comment 3 Frédérick Capovilla 2011-04-21 17:47:47 UTC
Comment on attachment 3969 [details] [review]
Corrects a problem where the "Saved" message never disappeared on IE8.

Oh, I didn't notice humanmsg.js was an external jquery plugin... 
I'll check out the other solutions linked by Owen.

Made the patch obsolete, since it obviously isn't the good solution to the problem.
Comment 4 Frédérick Capovilla 2011-04-21 18:08:01 UTC
(In reply to comment #2)
> http://code.google.com/p/humanmsg/issues/detail?id=1
> 
> The edit suggested in Comment 1 seems to fix the problem in Internet Explorer
> 8. The second suggestion causes errors for me. I'd love to see this change
> tested in IE7 if anyone has it.

I tried the edits from Comment 1 on different browsers and here is the behavior :
IE6 : No box appears, so no problem.
IE7, IE8, Firefox 3.6.16 : Box doesn't disappear automatically, but disappears when the mouse is moved.

That fix seems to work. making a patch...
Comment 5 Frédérick Capovilla 2011-04-21 18:14:59 UTC Comment hidden (obsolete)
Comment 6 Paul Poulain 2011-08-10 12:38:12 UTC
Created attachment 4934 [details] [review]
proposed patch (passed QA)

QA comment

* this patch fixes a problem in syspref management/savinr in staff interface, in IE8. First of all, Koha is not guaranteed to work under IE8.
* I don't have IE, I have checked that the behaviour is still OK under FF. It's the case
* just a minor comment = the patch don't contain the bug number. If would have been better, but won't reject passed QA just for this minor forgotten string.
Comment 7 Chris Cormack 2011-08-11 00:13:30 UTC
Pushed, (and fixed the commit message to contain bug number)