Created attachment 3969 [details] [review] Corrects a problem where the "Saved" message never disappeared on IE8. The problem happens after the patch from Bug 5862 is applied to let the user save system preferences on IE8 : When new settings are saved, the message "Saved" appears in the middle of the screen in a black box. This box closes automatically in firefox, but not in IE8. It seems a timeout of "Infinity" is used to close the box. On IE8, this means the box is never closed. I changed the default timeout value from "Infinity" to 2000 (2 seconds), and now the box disappears correctly on IE8. Patch attached.
I think the problem is not that the timeout is interpreted incorrectly, I think the problem is that IE doesn't recognize the event which should hide the message. The "infinity" behavior is desirable because it leaves the message on the screen indefinitely--unless some event occurs to trigger hiding it. A mouse movement seems to suffice in standards-compliant browsers. I think this is nice because if you switch away from your browser the message remains until you return. I'd like to find out whether this behavior can be made to work in IE.
http://code.google.com/p/humanmsg/issues/detail?id=1 The edit suggested in Comment 1 seems to fix the problem in Internet Explorer 8. The second suggestion causes errors for me. I'd love to see this change tested in IE7 if anyone has it.
Comment on attachment 3969 [details] [review] Corrects a problem where the "Saved" message never disappeared on IE8. Oh, I didn't notice humanmsg.js was an external jquery plugin... I'll check out the other solutions linked by Owen. Made the patch obsolete, since it obviously isn't the good solution to the problem.
(In reply to comment #2) > http://code.google.com/p/humanmsg/issues/detail?id=1 > > The edit suggested in Comment 1 seems to fix the problem in Internet Explorer > 8. The second suggestion causes errors for me. I'd love to see this change > tested in IE7 if anyone has it. I tried the edits from Comment 1 on different browsers and here is the behavior : IE6 : No box appears, so no problem. IE7, IE8, Firefox 3.6.16 : Box doesn't disappear automatically, but disappears when the mouse is moved. That fix seems to work. making a patch...
Created attachment 3980 [details] [review] Corrects the behavior of the humanmsg box on IE8 and IE7. New patch attached. This is the fix that was mentioned in Comment 2 of this bug.
Created attachment 4934 [details] [review] proposed patch (passed QA) QA comment * this patch fixes a problem in syspref management/savinr in staff interface, in IE8. First of all, Koha is not guaranteed to work under IE8. * I don't have IE, I have checked that the behaviour is still OK under FF. It's the case * just a minor comment = the patch don't contain the bug number. If would have been better, but won't reject passed QA just for this minor forgotten string.
Pushed, (and fixed the commit message to contain bug number)