Bug 6236 - cannot receive serials
Summary: cannot receive serials
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) blocker (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 14:48 UTC by Jared Camins-Esakov
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.02 KB, patch)
2011-04-21 16:08 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2011-04-21 14:48:22 UTC
If you try to receive an item with a date prior to today, the template throws up an error about Date::Calc::Add_Delta_Days.
Comment 1 Nicole C. Engard 2011-04-21 15:16:42 UTC
You can no longer receive serials - this looks like the date error that we had before that Colin fixed.  I'm upgrading the severity here since it's a blocker you cannot receive serials at all without getting the error Jared mentioned.
Comment 2 Nicole C. Engard 2011-04-21 15:19:51 UTC
Error message:


Software error:
Date::Calc::Delta_Days(): not a valid date at /home/nengard/kohaclone/C4/Serials.pm line 1641.
For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error.
Comment 3 Nicole C. Engard 2011-04-21 15:23:39 UTC
btw I tested this on the TT version and the HTML version - same error in both places.
Comment 4 Colin Campbell 2011-04-21 16:06:05 UTC
Its data related. The code is not dealing correctly with some dates (or rather non-dates) occurring in serials.
(Thanks for the error-message Nicole)

I think I've found some templating issues in receipting as well
Comment 5 Colin Campbell 2011-04-21 16:08:49 UTC
Created attachment 3974 [details] [review]
Proposed Patch

This patch should fix the Dates error message. However I see to hit a template error when receipting, having resolved this
Comment 6 Nicole C. Engard 2011-04-21 16:17:07 UTC
Not sure what you're saying ... but this patch did fix the problem on new subscriptions - it didn't help my borked one ... but I think we should be fine so I'm signing off.
Comment 7 Chris Cormack 2011-04-21 19:36:47 UTC
Pushed, please test
Comment 8 Katrin Fischer 2011-04-24 10:54:06 UTC
I tested this by receiving issues for a serial starting from January to present. I had no problems, plz reopen bug when I missed something.