Bug 6237 - Recent changes leave compile time warnings in additem.pl
Summary: Recent changes leave compile time warnings in additem.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 15:04 UTC by Colin Campbell
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.33 KB, patch)
2011-04-21 15:14 UTC, Colin Campbell
Details | Diff | Splinter Review
Proposed patch for C4::Auth (890 bytes, patch)
2011-04-21 15:15 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2011-04-21 15:04:08 UTC
After recent changes additem.pl a couple of compile time warnings have crept into cataloguing/additem.pl due to global variables being declared in two places. Remove the duplicates. Additem is also showing a compile time error from C4::Auth due to a line which serves no purpose in there
Comment 1 Colin Campbell 2011-04-21 15:14:57 UTC
Created attachment 3970 [details] [review]
Proposed Patch
Comment 2 Colin Campbell 2011-04-21 15:15:44 UTC
Created attachment 3971 [details] [review]
Proposed patch for C4::Auth
Comment 3 Chris Cormack 2011-04-21 19:32:02 UTC
THanks for the catch Colin. Pushed
Comment 4 Katrin Fischer 2011-04-25 17:12:06 UTC
How to test that? Add items and check the logs for entries?
Comment 5 Colin Campbell 2011-04-26 13:04:15 UTC
Test with perl -wc additem.pl run the compile pass on the script with warnings enabled
Comment 6 Jared Camins-Esakov 2012-12-31 00:14:23 UTC
There have been no further reports of problems so I am marking this bug resolved.