Bug 6259 - AllowHoldPolicyOverride ON causes every staff hold to require override
Summary: AllowHoldPolicyOverride ON causes every staff hold to require override
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 04:12 UTC by D Ruth Holloway
Modified: 2012-10-25 23:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description D Ruth Holloway 2011-04-25 04:12:19 UTC 
if AllowHoldPolicyOverride is turned on, any attempt in the staff client to place a hold will require override, even if it should not.  Turning the syspref OFF lets normal rules take over.

In reserve/request.pl, right after the comment " If AllowHoldPolicyOverride is set, it should override EVERY..." (circa line 444-450) seems to be the crux of the matter.  It should, I suspect, check to see if item->{available} is already *set* before setting $item->{override}.
Comment 1 Chris Cormack 2011-04-27 04:22:17 UTC 
Pushed, please test
Comment 2 Robin Sheat 2011-06-23 09:17:40 UTC 
Tested, works on both master and 3.4.x
Comment 3 Robin Sheat 2011-06-23 09:21:00 UTC 
To clarify, afaik it hasn't been pulled into 3.4.x, but it should be and it works there.