Bug 6269 - can't undefine a printer profile
Summary: can't undefine a printer profile
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) critical
Assignee: Chris Nighswonger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 16:34 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Fix (5.03 KB, patch)
2011-08-17 15:27 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Fix (5.25 KB, patch)
2011-08-19 15:03 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Bug 6269 - can't undefine a printer profile (5.28 KB, patch)
2011-08-19 15:16 UTC, Chris Nighswonger
Details | Diff | Splinter Review
[Signed Off] Bug 6269 - can't undefine a printer profile (5.34 KB, patch)
2011-08-19 15:21 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-04-26 16:34:35 UTC
once you define a printer profile in the Label Creator Templates, you can't undefine it
Comment 1 Chris Nighswonger 2011-08-17 15:27:46 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2011-08-19 14:58:17 UTC
http://screencast.com/t/kFcTv663m

This patch does allow one to unset the printer profile, but the display is misleading when one goes to edit the template again, it shows the first item in the list of the profile drop down (and I can only assume if you saved the form, it would reset the printer to the first printer in the list).
Comment 3 Chris Nighswonger 2011-08-19 15:03:04 UTC Comment hidden (obsolete)
Comment 4 Chris Nighswonger 2011-08-19 15:16:31 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2011-08-19 15:21:14 UTC
Created attachment 5064 [details] [review]
[Signed Off] Bug 6269 - can't undefine a printer profile

This patch adds a 'No Profile/N/A' selection to the printer profile
drop-down menu along with code to handle the selection of it. This
selection is the default selection for new templates.

Documentation should be updated to reflect this change.

Signed-off-by: Liz Rea <lrea@nekls.org>
Comment 6 Chris Cormack 2011-08-21 07:58:43 UTC
Patch pushed, please test
Comment 7 Chris Nighswonger 2011-10-12 19:51:50 UTC
Please test and mark resolve/fixed.