- Exclude 'marc' & 'item' prefix from UNIMARC util XSL to slim down result - Add missing NSB/NSE characters striping - 200 fields on result/detail page: show all subfields in order, link to detail page only on $a - 4xx display, more fields and more subfields, respects subfields order which matter - Add missing fields: 205, 500 - Add missing MARC21 syspref: - DisplayOPACiconsXSLT, not implemtable in UNIMARC - OPACURLOpenInNewWindow - URLLinkText - ShowISBD Sidenote: this should have been done by people having introduced those syspref into MARC21 XSL.
Created attachment 4048 [details] [review] Proposed patch
This patch yields displaying problems on unimarc data: "Jules César : tragédie[Texte imprimé]" => Title Information and Material Designation are stuck "Henri VI ou La guerre des deux roses[Texte imprimé]" the same with title and Material Designation ", InstitutionBouquin : Autre nom du bouquin" => the title is "Bouquin", a field 200$5 is inserted before without space.
Created attachment 4600 [details] [review] Corrected proposed patch
(In reply to comment #2) New patch fixing errors and adding RAMEAU authorities subdivisions linking
I think it's a good thing to show 200 subfileds in order, but when i have some subfields before $a in the marcxml, i have some displaying problems. For exemple, when a record has the following in marcxml: <datafield tag="200" ind1=" " ind2=" "> <subfield code="5">Institution</subfield> <subfield code="a">Livre</subfield> <subfield code="e">Autre titre du livre</subfield> </datafield> I get on opac results: : Autre titre du livre, InstitutionLivre / Jean Should we consider it's a marcxml problem and the $a should always be at the top or should the display be adapted in this case ?
(In reply to comment #5) > I think it's a good thing to show 200 subfileds in order, but when i have some > subfields before $a in the marcxml, i have some displaying problems. > > For exemple, when a record has the following in marcxml: > <datafield tag="200" ind1=" " ind2=" "> > <subfield code="5">Institution</subfield> > <subfield code="a">Livre</subfield> > <subfield code="e">Autre titre du livre</subfield> > </datafield> > > I get on opac results: > > : Autre titre du livre, InstitutionLivre / Jean > > Should we consider it's a marcxml problem and the $a should always be at the > top or should the display be adapted in this case ? Good question and thanks for testing! I can't say if those kind of records are valid or common. I haven't biblio records like that to test with. So I would suggest to sign-off this patch if there isn't any other issue and submit a followup patch to fix this issue.
Updating Version : This ENH will be for Koha 3.8
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Patch still applies and includes important enhancements. I am missing UNIMARC records for testing this bug and others - perhaps some records can be attached or a small database stored somewhere for testing purposes?
Created attachment 7436 [details] [review] XSL UNIMARC Improvments - Exclude 'marc' & 'item' prefix from UNIMARC util XSL to slim down result - Add missing NSB/NSE characters striping - 200 fields on result/detail page: show all subfields in order, link to detail page only on $a - 4xx display, more fields and more subfields, respects subfields order which matter - Improve RAMEAU authorities linkings to subdivisions (pure XSLT) - Add missing fields: 205, 500 - Add missing MARC21 syspref: - DisplayOPACiconsXSLT, not implemtable in UNIMARC - OPACURLOpenInNewWindow - URLLinkText - ShowISBD Sidenote: this should have been done by people having introduced those syspref into MARC21 XSL. Suite http://bugs.koha-community.org/show_bug.cgi?id=6314 Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Created attachment 7437 [details] [review] [SIGNED OFF] Bug 6314 XSL UNIMARC Improvments - Exclude 'marc' & 'item' prefix from UNIMARC util XSL to slim down result - Add missing NSB/NSE characters striping - 200 fields on result/detail page: show all subfields in order, link to detail page only on $a - 4xx display, more fields and more subfields, respects subfields order which matter - Improve RAMEAU authorities linkings to subdivisions (pure XSLT) - Add missing fields: 205, 500 - Add missing MARC21 syspref: - DisplayOPACiconsXSLT, not implemtable in UNIMARC - OPACURLOpenInNewWindow - URLLinkText - ShowISBD Sidenote: this should have been done by people having introduced those syspref into MARC21 XSL. Suite http://bugs.koha-community.org/show_bug.cgi?id=6314 Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
QA comment: XSLT only patch. Unimarc only, nothing to say
This was set to pushed by Paul - so I think it's not master.