Bug 6318 - fields missing when editing a layout
Summary: fields missing when editing a layout
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 16:15 UTC by Nicole C. Engard
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
patch (9.61 KB, patch)
2011-09-05 08:47 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[SIGNED-OFF] bug_6318: Always give predefined fields drop downs on label layout edit (9.68 KB, patch)
2011-09-06 14:05 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-05-06 16:15:34 UTC
When you create a layout you have 7 (i think) fields you can choose from under the 'Choose Order Of Text Fields to Print' heading.  If you set any of them to 'blank' (aka not to show) then when you come back to edit the label those fields aren't there as a choice anymore.  

For those of us who know the database and the marc fields it's not a big deal, we can use the box under the 'List fields' heading, but for most librarians it's confusing to have those fields disappear. I think that they should be there at all times that way librarians can just choose a number from the pull down to make them reappear.

Another option is to have a menu like on notices where all the fields are listed and you choose which ones you want to add to your label.
Comment 1 Srdjan Jankovic 2011-09-05 08:47:54 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2011-09-06 14:05:28 UTC
Created attachment 5316 [details] [review]
[SIGNED-OFF] bug_6318: Always give predefined fields drop downs on label layout edit

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Ian Walls 2011-09-15 13:07:26 UTC
Changes to subroutine output are completely self-contained to labels/label-edit-layout.pl, and all usages are updated to reflect new output.  Marking as Passed QA.
Comment 4 Chris Cormack 2011-09-15 23:26:38 UTC
Pushed to master, please test
Comment 5 Chris Nighswonger 2011-10-26 18:02:19 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
Comment 6 Jared Camins-Esakov 2012-12-31 00:13:58 UTC
There have been no further reports of problems so I am marking this bug resolved.