When an item move fails, the current behavior is to send the user back to the MARC detail page only. I believe there should be an option to "try again with a different barcode."
Created attachment 4064 [details] [review] Proposed patch This patch adds "Try again with a different barcode" to the error options, and modifies the OK button to go back to the standard detail instead of the MARC detail page.
Created attachment 4072 [details] [review] This patch replaces the other one This patch adds button to retry attaching item, addes default bib view handling, cosmetic changes to the error display (buttons now in error div). This is the correct, complete patch (thanks, I'm still learning)
Comment on attachment 4064 [details] [review] Proposed patch this patch is lesser than the other, please use it instead.
QA comment Sorry, but the patch doesn't apply anymore, and it seems it's not only a glitch I can fix while QAing. => does not apply
Created attachment 5628 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div).
I thought it was clearer when the button said "Try a different barcode."
Updating Version : This ENH will be for Koha 3.8
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Created attachment 6249 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div).
Comment on attachment 6249 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt This latest patch changes the wording back to "try again with a different barcode"
Created attachment 6331 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6332 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA Comment: You use form method=link in the template. This is not an official method in html. It should be get or post. I tried to find another example in current Koha code/template, but it is not present. So I think we should not introduce it, although it probably works. Links should be <a> tags; you can customize layout with css. The action block contains ending tags without opening tags. This may work since the opening tags could be before the include. But for maintenance, I would personally not favor it. It would be better if this block is correct on its own.
Created attachment 6870 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6872 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6874 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). Incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6875 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). Incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6908 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). Incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended.
Created attachment 6927 [details] [review] Bug 6323 -- Error handling cleanup for moveitem.tt Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div). Incorporates changes that should satisfy QA. To test: Find a bib with multiple items and grab one of the barcodes. Go to a second bib and click Edit -> Attach item Paste your barcode in there and click "Submit" Click the "Try again with a different barcode" button. It should take you back to the barcode entry screen. Also try with a non-existent barcode and verify that the button appears and works as intended. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA Comment: Changed to satisfy earlier comments. Thanks. Looks good. Updating status..