Bug 6329 - patron categories should show which fields are required
Summary: patron categories should show which fields are required
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 16:13 UTC by Nicole C. Engard
Modified: 2013-12-05 20:09 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
error about required fields not being filled in (103.53 KB, image/png)
2011-05-11 16:13 UTC, Nicole C. Engard
Details
all possible errors/required fields (51.28 KB, image/png)
2011-05-11 16:18 UTC, Nicole C. Engard
Details
Bug 6329 - patron categories should show which fields are required (3.02 KB, patch)
2013-05-14 19:12 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6329 - patron categories should show which fields are required (3.05 KB, patch)
2013-05-15 03:45 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 6329 - patron categories should show which fields are required (3.17 KB, patch)
2013-05-15 05:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-05-11 16:13:17 UTC
Created attachment 4076 [details]
error about required fields not being filled in

When you're adding or editing patron category the required fields aren't marked as required. There should be a red start or some sort of indication of what fields are required.
Comment 1 Nicole C. Engard 2011-05-11 16:18:56 UTC
Created attachment 4077 [details]
all possible errors/required fields
Comment 2 Owen Leonard 2013-05-14 19:12:53 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2013-05-15 03:45:02 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-05-15 05:30:48 UTC
Created attachment 18141 [details] [review]
[PASSED QA] Bug 6329 - patron categories should show which fields are required

When entering a new patron category, required fields are not indicated
on the entry form. This patch adds the "required" class to the relevant
labels.

To test, add or edit a patron category. Confirm that the required fields
(category code, category type, description, and enrollment period) are
indicated as being required with a red label.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.
Template changes only, but no string changes.
Comment 5 Jared Camins-Esakov 2013-05-15 11:26:04 UTC
This patch has been pushed to master and 3.12.x.