6337 – Variable scope errors in staff client cart print view

Bug 6337 - Variable scope errors in staff client cart print view

Summary: Variable scope errors in staff client cart print view

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	PATCH-Sent (DO NOT USE) normal
Assignee:	Owen Leonard
QA Contact:	Bugs List

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-13 14:57 UTC by Owen Leonard
Modified:	2013-12-05 19:57 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed fix (2.32 KB, patch) 2011-05-13 15:01 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Signed off Patch (2.35 KB, patch) 2011-05-15 08:32 UTC, Chris Cormack	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2011-05-13 14:57:31 UTC

Some T:T variable scope errors in the staff client cart template cause bad formatting of the print view.

Comment 1 Owen Leonard 2011-05-13 15:01:47 UTC Comment hidden (obsolete)

Created attachment 4106 [details] [review]
Proposed fix

    Also removing "Return to cart" link from the print view,
    redundant now that the print view prints and redirects
    automatically.

Comment 2 Chris Cormack 2011-05-15 08:32:55 UTC

Created attachment 4118 [details] [review]
Signed off Patch

Comment 3 Ian Walls 2011-06-03 20:42:29 UTC

Straightforward template change, marking as Passed QA

Comment 4 Chris Cormack 2011-06-04 08:02:02 UTC

Pushed to master, please test