Bug 6342 - Help link doesn't popup anymore contextual help page
Summary: Help link doesn't popup anymore contextual help page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Frédéric Demians
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-15 05:13 UTC by Frédéric Demians
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed patch for testing and signing off (3.01 KB, patch)
2011-05-15 05:17 UTC, Frédéric Demians
Details | Diff | Splinter Review
Signed off Patch (3.08 KB, patch)
2011-05-15 08:27 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2011-05-15 05:13:44 UTC
Click on the top right corner ? link. The contextual help page doesn't popup.
Comment 1 Frédéric Demians 2011-05-15 05:17:32 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-05-15 08:27:30 UTC
Created attachment 4117 [details] [review]
Signed off Patch

Works perfectly
Comment 3 Ian Walls 2011-05-25 12:26:26 UTC
Passed QA; confirmed that this also works for pages without Help files.

One incredibly minor thing to note is that the URL for the help pages includes a param, url=undefined, that does not seem to do anything.  Removing it would be a purely cosmetic change, but I'm noting it here.
Comment 4 Chris Cormack 2011-05-28 06:56:13 UTC
Pushed please test