Bug 6405 - Volume info (enumchron) not shown on the "Place Hold" screen
Summary: Volume info (enumchron) not shown on the "Place Hold" screen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-25 03:12 UTC by Srdjan Jankovic
Modified: 2013-12-05 19:53 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (3.62 KB, patch)
2011-05-25 03:31 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
Signed off patch (3.73 KB, patch)
2011-05-25 06:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
screenshot: Normal view in intranet (17.88 KB, image/png)
2011-05-25 06:07 UTC, Katrin Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Srdjan Jankovic 2011-05-25 03:12:40 UTC
Volume info (enumchron) not shown on the "Place Hold" screen. It is shown on the OPAC hold interface.
Comment 1 Srdjan Jankovic 2011-05-25 03:31:38 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-05-25 06:04:18 UTC
Created attachment 4252 [details] [review]
Signed off patch
Comment 3 Katrin Fischer 2011-05-25 06:07:03 UTC
Created attachment 4253 [details]
screenshot: Normal view in intranet
Comment 4 Katrin Fischer 2011-05-25 06:07:21 UTC
While testing I found that my enumchron doesn't show correctly in staff's detail view (see attached screenshot). I checked a serial record and a monograph, both displays were the same and the information not shown. (see screenshot)
Comment 5 Nicole C. Engard 2011-05-25 11:38:17 UTC
Katrin is that bug 6397?
Comment 6 Katrin Fischer 2011-05-25 14:04:06 UTC
From the description I think so. Adding as 'See also'.
Comment 7 Paul Poulain 2011-08-11 09:59:10 UTC
(In reply to comment #4)
> While testing I found that my enumchron doesn't show correctly in staff's
> detail view (see attached screenshot). I checked a serial record and a
> monograph, both displays were the same and the information not shown. (see
> screenshot)

Katrin,

There's something that I'm not sure to understand: You signed-off the patch but added a comment saying "doesn't show correctly".
Maybe it means the patch is incomplete, fixes some screens but there are others ? Thanks to clarify !
Comment 8 Katrin Fischer 2011-08-11 10:17:57 UTC
The patch fixes the holds screens in staff and opac - so it does what it's supposed to do.
I noticed a problem on the detail screen while testing - not sure it's still there though.
Comment 9 Srdjan Jankovic 2011-08-12 01:05:20 UTC
Then I suggest we close this one, and open another bug for that other screen?
Comment 10 Katrin Fischer 2011-08-12 05:06:24 UTC
Hi Srdjan - the other problem needs to be retested. I will try to do so and file a bug when it's still there (should have done so the first time around). 
Please don't close the bug yet as your fix for the holds screens has not yet been pushed.
Comment 11 Paul Poulain 2011-10-06 14:09:13 UTC
QA comment:
* clear description
* small patch, nothing to say from a QA point of view

Katrin, would you be willing to open another bug for the remaining display problem ?

marking passed QA
Comment 12 Katrin Fischer 2011-10-07 04:42:04 UTC
I retested on current master and enumchron shows correctly on staff detail page now. So opening another bug is not necessary.
Comment 13 Chris Cormack 2011-10-09 07:03:16 UTC
Patch pushed, please test
Comment 14 Jared Camins-Esakov 2012-05-23 12:12:03 UTC
This appears to be working. Closing.