Bug 6450 - No check in/check out messages in message_queue
Summary: No check in/check out messages in message_queue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major
Assignee: Magnus Enger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 19:09 UTC by Magnus Enger
Modified: 2012-10-25 23:09 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed patch (1.00 KB, patch)
2011-06-02 19:40 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 6450 - No check in/check out messages in message_queue (1.05 KB, patch)
2011-06-03 01:05 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2011-06-02 19:09:33 UTC
On 3.4.x and current master no messages for check in/check out are stored in message_queue. See this message to koha-devel for further description of the problem: http://lists.koha-community.org/pipermail/koha-devel/2011-June/035692.html 

Patch coming in a moment - huge thanks to Katrin Fischer who spotted what the problem was!
Comment 1 Magnus Enger 2011-06-02 19:40:51 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2011-06-02 19:45:08 UTC
Forgot to mention that the patch should be applied to both master and the 3.4.x branch, if it passes QA.
Comment 3 Chris Cormack 2011-06-03 01:05:21 UTC
Created attachment 4348 [details] [review]
Bug 6450 - No check in/check out messages in message_queue

Huge thanks to Katrin Fischer for spotting what was the trouble here!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Ian Walls 2011-06-30 18:51:42 UTC
This is exactly the change this bug needs (was just in the code myself the other day).  Marking as Passed QA.
Comment 5 Chris Cormack 2011-07-02 20:58:21 UTC
Pushed to master please test
Comment 6 Robin Sheat 2011-08-18 05:24:31 UTC
Confirmed that this fixes it in 3.4.x