As far as I can see, line 194 in C4::Templates::themelanguage() is not needed: my $dbh = C4::Context->dbh; $dbh does not seem to be used again in the scope in which it is created. Patch coming up.
Created attachment 4358 [details] [review] Proposed patch
Created attachment 4385 [details] [review] Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage() As far as I can tell, $dbh is never used again in the scope in which it is created. This patch simply removes the line. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Yep, it is a needless call, signed off
And pushed to master