Bug 6459 - Needless call to C4::Context->dbh in C4::Templates::themelanguage()
Summary: Needless call to C4::Context->dbh in C4::Templates::themelanguage()
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Magnus Enger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 17:49 UTC by Magnus Enger
Modified: 2012-10-25 23:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (896 bytes, patch)
2011-06-04 17:53 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage() (960 bytes, patch)
2011-06-06 20:26 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2011-06-04 17:49:15 UTC
As far as I can see, line 194 in C4::Templates::themelanguage() is not needed: 

my $dbh = C4::Context->dbh;

$dbh does not seem to be used again in the scope in which it is created. 

Patch coming up.
Comment 1 Magnus Enger 2011-06-04 17:53:59 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-06-06 20:26:13 UTC
Created attachment 4385 [details] [review]
Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage()

As far as I can tell, $dbh is never used again in the scope in which it is
created. This patch simply removes the line.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Chris Cormack 2011-06-06 20:26:40 UTC
Yep, it is a needless call, signed off
Comment 4 Chris Cormack 2011-06-09 23:21:48 UTC
And pushed to master