Created attachment 4431 [details] no due date sort See attached, I can sort by many of the columns on my summary in the OPAC, but not the due date which seems like the one field most people would want to sort by. This option was there in 3.2 but is not there in master right now.
Just a little ping on this one - I'm thinking it's relatively easy to get this added back in ... for someone who knows what they're doing.
I believe this is only an issue if you have barcodes enabled in the opac-summary. The tablesorter columns get moved over by one in that case.
Created attachment 4607 [details] [review] Proposed fix Columns on the summary table are shown or hidden based on a variety of different settings, leading to convoluted if/else template constructions if we want to define header sorting in the <script> block. Using the jQuery Metadata plugin allows us to specify sorting options as classes on the table header. This adds a dependency but simplifies the template markup significantly. I recommend continuing to specify header sort options in the <script> block in cases where it is relatively simple to do so and saving inclusion of the additional jQuery plugin for pages which really need it. Other changes: Moved common sorter configuration detalis to default declaration; Moved the date due column so that it could be set as the default sort without taking into account multiple disappearing columns (default sort cannot be set in the markup for a <th>).
Patch is clean and readable, well explained. Works in my testing. Marking as Passed QA.
Works well, pushed to master, please test