Bug 6484 - Due date sorter on 'my summary' missing
Summary: Due date sorter on 'my summary' missing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 18:12 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
no due date sort (60.16 KB, image/png)
2011-06-08 18:12 UTC, Nicole C. Engard
Details
Proposed fix (10.57 KB, patch)
2011-07-08 16:26 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-06-08 18:12:40 UTC
Created attachment 4431 [details]
no due date sort

See attached, I can sort by many of the columns on my summary in the OPAC, but not the due date which seems like the one field most people would want to sort by.  This option was there in 3.2 but is not there in master right now.
Comment 1 Nicole C. Engard 2011-06-29 19:22:36 UTC
Just a little ping on this one - I'm thinking it's relatively easy to get this added back in ... for someone who knows what they're doing.
Comment 2 Ian Walls 2011-07-06 15:08:10 UTC
I believe this is only an issue if you have barcodes enabled in the opac-summary.  The tablesorter columns get moved over by one in that case.
Comment 3 Owen Leonard 2011-07-08 16:26:43 UTC
Created attachment 4607 [details] [review]
Proposed fix

Columns on the summary table are shown or hidden based on a
variety of different settings, leading to convoluted if/else
template constructions if we want to define header sorting
in the <script> block. Using the jQuery Metadata plugin
allows us to specify sorting options as classes on the
table header. This adds a dependency but simplifies the
template markup significantly.

I recommend continuing to specify header sort options in the
<script> block in cases where it is relatively simple to do
so and saving inclusion of the additional jQuery plugin for
pages which really need it.

Other changes: Moved common sorter configuration detalis to
default declaration; Moved the date due column so that it
could be set as the default sort without taking into account
multiple disappearing columns (default sort cannot be set
in the markup for a <th>).
Comment 4 Ian Walls 2011-07-20 18:57:00 UTC
Patch is clean and readable, well explained.  Works in my testing.  Marking as Passed QA.
Comment 5 Chris Cormack 2011-07-20 20:33:35 UTC
Works well, pushed to master, please test