The checkout slip is currently rather informative, and could use a few improvements: * The branchname should not be displayed if it is the same as the global LibraryName. * The address should be displayed on the slip. This more closely matches the behavior of other ILSes.
Created attachment 4433 [details] [review] Bug 6485 - Checkout slip should be more useful This patch makes the following improvements to the checkout slip: * Does not show the branchname if it is the same as the global LibraryName, which is useful for single-library catalogs. * Shows branchaddress* information. This is wrapped in a <div> with class .slip-address-info, making it easy to disable with intranetuserjs... * ... which has been added to the checkout slip.
One thing I don't understand here is <script language="javascript"> function printThenClose() { + return; window.print(); window.close(); } </script> Why the return ? (I don't fully grok javascript so it might just be me being dense)
QA comment: Chris, you're not dense: function printThenClose() { + return; window.print(); window.close(); } means window.print & window.close will never be reached. 2 options : * it's was for testing purposes & forgotten to be removed (my bet) * .print & .close can be removed Anyway, failed QA !
This patch may become moot if 7001 passes.
the enhancements introduced by bug 7001 should fix this issue.