As described by Ian Walls: "On current HEAD, zebraqueue entries that point to deleted biblios are returning an error, and preventing every other done=0 entry from being indexed. I'm not sure if this is occurring after ANY deletion of a biblio, or only through specific vectors like reverting an imported batch, but it's a major problem. ... The exact error being returned by the rebuild_zebra.pl cronjob is: Can't call method 'field' on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 361."
Created attachment 4442 [details] [review] Bug 6492 - Deleted biblios cause rebuild_zebra to fail This both adds a bit of a failsafe to get_raw_biblio, and prevents records that have been deleted from being updated by the same instance of rebuild_zebra.
Looks like this is a duplicate of 6384.
Also a duplicate of 5724. Apologies, was in a hurry when filing the bug. Anyway, 5724 and this bug both have patches that solve the same problem. Which patch should we go with, and what bug should be the master one?
Personnaly, I think that we should stick to bug 5724 solution. Because it appears to me that the rebuild_zebra, with your patch would not export any marc record for deleted_biblios since it won't take them from the deletedbiblioitems table. So if you would solve the problem of the warning, you would not solve the problem that entries in zebra are not deleted.... And you would need a rebuild_zebra -b -r Which on big database is a bit harmful.
Marking this bug as critical, since it prevents any newly added items or titles from showing up in the catalog, and those are often some of the most important things to patrons. The fix for 5724 is dependent on 5725, which is a big bit of work. I'd like to decouple the fixing of this issue from the implementation of batch biblio modification, since this issue is critical, and batch biblio mod is an enhancement (though, yes, a very important one)... N
*** Bug 6384 has been marked as a duplicate of this bug. ***
Created attachment 4491 [details] [review] [SIGNED-OFF] Bug 6492 - Deleted biblios cause rebuild_zebra to fail This both adds a bit of a failsafe to get_raw_biblio, and prevents records that have been deleted from being updated by the same instance of rebuild_zebra. Minor amendment to remove duplication of 6433 Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Pushed, please test
I tested it on 3.05.00.004 as downloaded today, 2011-07-05, via git. It works!
Thanks very much for testing Bob :)