http://wiki.koha-community.org/wiki/Simplified_syspref_handling_RFC
Created attachment 4524 [details] [review] Proof-of-concept patc 1/3
Created attachment 4525 [details] [review] Proof-of-concept patch 2/3
Created attachment 4526 [details] [review] Proof-of-concept patch 3/3
Please note: The three attached patches are not a complete implementation of what I propose to do, but are meant as a "proof of concept" to see if this is the right way to do it. The changes are also available here: https://github.com/MagnusEnger/kohawork/commits/bug6537-sysprefs To test: - Apply the patches - Run through the web installer in English - Check that sysprefs work as expected - Install German translations - Run through the web installer in German - Check that sysprefs work as expected - Check that borrowerRelationship = Vater|Mutter and BorrowersTitles = Herr|Frau Questions: - Does this look like a feasible way of simplifying the handling of sysprefs for the web installer? - Should I delete unused columns (explanation, options?) from the systempreferences table while I'm at it? TODO - Create simplified syspres.sql files for all languages - See http://wiki.koha-community.org/wiki/Simplified_syspref_handling_RFC#Things_to_remember for more
Created attachment 4875 [details] [review] Patch 1/5 - Make English sysprefs the default
Created attachment 4876 [details] [review] Patch 2/5 - Make web installer use default sysprefs file
Created attachment 4877 [details] [review] Patch 3/5 - New, simplified sysprefs files for all the languages
Created attachment 4878 [details] [review] Patch 4/5 - Remove syspref related tests in xt/
Created attachment 4879 [details] [review] Patch 5/5 - Fix a problem in French syspref file
Changes are also available here: https://github.com/MagnusEnger/kohawork/commits/bug6537-sysprefs I'll send a proper "request to pull" to the patches list once I figure out how to do it (again)...
Created attachment 4903 [details] [review] proposed fix signed-off and squashed Works perfectly. I've tested with french setup, all sysprefs are here after install. Some are already translated if I checked the "update french unimarc syspref" in the last part of the installer (pre-load datas)
Created attachment 4904 [details] [review] follow-up for french UNIMARC This follow-up just removes some lines that are not UNIMARC specific and have no reason to differ from the common/default setup
Created attachment 4905 [details] [review] Signed off Paul's followup patch I can't speak to the French spellings or anything, but the followup patch from Paul does what it says and produces a valid SQL file in the end, so I'm signing off.
The actual code of these patches is quite minimal, and has been verified to work. The bulk of the changes are moving data about; since what was the English file was just moved to the default file, and the differences in values taken and placed into update files. While I do not have the language skills to evaluate every language here, I can mark the mechanic as Passing QA; any language-specific issues that come up can be addressed as they're discovered.
Pushed, please test with a new install
I think this is in Stable now, isn't it? Related but maybe off-topic: should all Pushed to Master bugs become Pushed to Stable on a new major version release? Shall I try to identify and change likely suspects?
(In reply to comment #16) > I think this is in Stable now, isn't it? > > Related but maybe off-topic: should all Pushed to Master bugs become Pushed > to Stable on a new major version release? Shall I try to identify and change > likely suspects? That would be great, yes, this was in 3.6.0
This has been in use for a while now, without any complaints.