The circulation rules were not being applied at the item level, but at the biblio level when attempting to place holds on an item. We noticed the problem when the 942$c indicated an itype that did not allow holds, but that rule was still being applied when some of the items' 952$y should have made them regularly available. This doesn't seem to have been fixed in 3.4, as far as we could see on the git.
Created attachment 4554 [details] [review] logic change using items.itype instead of biblio We don't have git set up just yet. As soon as we do we'll submit it through there.
Created attachment 4557 [details] [review] Updated patch from git This replaces the previous patch we uploaded (since it's from the git and actually mentions the file we modified.
Hi Justin Pretty close, but unfortunately this line here $select .= " LEFT JOIN itemtypes ON biblioitems.itype = Won't work, its biblioitems.itemtype Can you please fix and resend Thank you Chris
Your patch is Bad. See http://wiki.koha-community.org/wiki/Coding_Guidelines Commiting Code
Hi Justin I think what Biblibre were trying to say, is your patch needs a better commit message, plus the little issue I spotted fixed up. As this is you first patch, we are happy to help you sort through any issues, either catch us on irc, or update the bug if you have something you don't understand or need help with. We always want new committers, so are happy to help you get your patch into tip top shape. Chris
I believe that this issue has been addressed by bug 4530. If I have misunderstood, my apologies, and please reopen the bug report! *** This bug has been marked as a duplicate of bug 4530 ***