Bug 6551 - applying lending rules by item-level itypes
Summary: applying lending rules by item-level itypes
Status: CLOSED DUPLICATE of bug 4530
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Justin @ Prosentient
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 01:13 UTC by Justin @ Prosentient
Modified: 2012-10-26 00:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
logic change using items.itype instead of biblio (759 bytes, patch)
2011-07-04 01:17 UTC, Justin @ Prosentient
Details | Diff | Splinter Review
Updated patch from git (1.02 KB, patch)
2011-07-05 04:22 UTC, Justin @ Prosentient
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Justin @ Prosentient 2011-07-04 01:13:14 UTC
The circulation rules were not being applied at the item level, but at the biblio level when attempting to place holds on an item. We noticed the problem when the 942$c indicated an itype that did not allow holds, but that rule was still being applied when some of the items' 952$y should have made them regularly available. This doesn't seem to have been fixed in 3.4, as far as we could see on the git.
Comment 1 Justin @ Prosentient 2011-07-04 01:17:32 UTC
Created attachment 4554 [details] [review]
logic change using items.itype instead of biblio

We don't have git set up just yet. As soon as we do we'll submit it through there.
Comment 2 Justin @ Prosentient 2011-07-05 04:22:44 UTC
Created attachment 4557 [details] [review]
Updated patch from git

This replaces the previous patch we uploaded (since it's from the git and actually mentions the file we modified.
Comment 3 Chris Cormack 2011-07-05 04:37:26 UTC
Hi Justin

Pretty close, but unfortunately this line here
 $select .= " LEFT JOIN itemtypes  ON biblioitems.itype  = 

Won't work, its biblioitems.itemtype

Can you please fix and resend

Thank you

Chris
Comment 4 dev_patches 2011-07-22 10:36:39 UTC
Your patch is Bad.
See 

http://wiki.koha-community.org/wiki/Coding_Guidelines

Commiting Code
Comment 5 Chris Cormack 2011-07-22 21:43:27 UTC
Hi Justin

I think what Biblibre were trying to say, is your patch needs a better commit message, plus the little issue I spotted fixed up.

As this is you first patch, we are happy to help you sort through any issues, either catch us on irc, or update the bug if you have something you don't understand or need help with.

We always want new committers, so are happy to help you get your patch into tip top shape.

Chris
Comment 6 Jared Camins-Esakov 2012-02-10 15:03:41 UTC
I believe that this issue has been addressed by bug 4530. If I have misunderstood, my apologies, and please reopen the bug report!

*** This bug has been marked as a duplicate of bug 4530 ***