If a corporate author's name includes parentheses, the tracing produced by the XSLT produces an invalid search.
Created attachment 4788 [details] Bug 6553 : Fixing authentication issue, there is no reason we should be able to use these without authentication
Created attachment 4789 [details] Bug 6553 : Follow up adding license statements
The content of attachment 4788 [details] has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2011-08-01 21:56:18 NZST.
The content of attachment 4789 [details] has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2011-08-01 21:56:37 NZST.
Working on this
This is okay using authorities, but yes is broken without. Fixing now
Actually brackets in authors is broken in both xslt and normal display, works in facets
Created attachment 5680 [details] [review] Proposed Patch Wraps author names in double-quotes on OPAC and staff client XSLT details pages
To test, create an author which contains parentheses? Is it only corporate author? I'd be happy to test if I can figure out how.
Created attachment 5991 [details] [review] [SIGNED-OFF] Bug 6553: parentheses in authors break tracings If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC and staff client fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: - Create a new framework, delete Thesaurus from 700 and other fields - Create a new record in this framework - Add 700$a - use parentheses - Check the search links in OPAC and staff detail pages > before patch link was broken, after it works Note: Links are only broken when no authorities are being used. When using authorities the link uses the auth number instead of the text for linking, so the parentheses don't matter for search.
XSLT-only change adding "" around authors to prevent tracings from breaking. As I would normally mark this as Passed QA, so shall I now, unless anyone objects.
Pushed please test
I believe this problem has come back. All the relevant fixed code is gone from master.
This has come back - the attachment doesn't apply anymore, will make a new patch. LR
Created attachment 18055 [details] [review] Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages
Created attachment 18445 [details] [review] Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 19303 [details] [review] [PASSED QA] Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change adding quotes. Search now matches search in the intranet. Passes all tests.
Pushed to master. Thanks, Liz!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Liz!
Pushed to 3.10.x, will be in 3.10.10