Created attachment 4565 [details] [review] Corrects the popup menu links in the z3950 search results. In the results of a Z39.50 search, if a result is clicked, a small popup menu appears with the options "Preview MARC","Preview Card","Import","X". If we compare the URL of the "Preview Marc" menu option and the URL of the "MARC" link on the same line, we can see that the "importid" is not the same in the two URLs. The importid in the popup menu seems to always be the importid of the last item of the results list. Patch attached that corrects the problem.
Do you have any idea why this bug does not come up in 3.3/3.5? The lines you move in the 3.2 template, are still in the same position too in master (in the tt template file).
Here is the corresponding change in master (Bug 6367): http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd985ea4e2bd80f9f0628f4cb4dd7c0
(In reply to comment #2) > Here is the corresponding change in master (Bug 6367): > http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd985ea4e2bd80f9f0628f4cb4dd7c0 Thanks for responding. I looked at acqui template. So I understand now that the same change should still be applied there (just as in cataloguing) ..
Patch does not apply to either current HEAD nor 3.2.x branch. Is this a backport only, and if so, to which version?
It applies fine for me on branch 3.2.x. git am -iu3 Patches/dl/0001-Corrects-the-popup-menu-links-in-the-z3950-search-re.patch Commit Body is: -------------------------- Corrects the popup menu links in the z3950 search results. The popup menu's options didn't link to the correct breedingid. -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Corrects the popup menu links in the z3950 search results. Using index info to reconstruct a base tree... <stdin>:16: trailing whitespace. <stdin>:39: trailing whitespace. warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl And it works.
Additionnal information : This patch was created on version 3.02.03.001 . Sorry for the inconvenience.
With 3.2.x ended, does this need to be reformatted for 3.4.x/master or is the bug not existent there?
I just tested this with Cataloging > Z39.50 Search on current master, and the problem is still there. All the popups use the "importid" of the record at the bottom of the list.
Magnus, it's working for me on master. See this video and watch the status bar showing the import id for each link: http://www.screencast.com/t/ZlUtyLemDJtb The links in each row match.
This needs a full rewrite if it is still needed
I think this has been fixed a longer time ago, please reopen if I am mistaken.