Bug 6556 - The popup menu in the Z39.50 search results doesn't point to the correct record.
Summary: The popup menu in the Z39.50 search results doesn't point to the correct record.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Frédérick Capovilla
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 18:53 UTC by Frédérick Capovilla
Modified: 2013-12-05 20:04 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Corrects the popup menu links in the z3950 search results. (2.65 KB, patch)
2011-07-05 18:53 UTC, Frédérick Capovilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2011-07-05 18:53:47 UTC
Created attachment 4565 [details] [review]
Corrects the popup menu links in the z3950 search results.

In the results of a Z39.50 search, if a result is clicked, a small popup menu appears with the options "Preview MARC","Preview Card","Import","X".
If we compare the URL of the "Preview Marc" menu option and the URL of the "MARC" link on the same line, we can see that the "importid" is not the same in the two URLs. 
The importid in the popup menu seems to always be the importid of the last item of the results list.

Patch attached that corrects the problem.
Comment 1 Marcel de Rooy 2011-07-06 11:50:09 UTC
Do you have any idea why this bug does not come up in 3.3/3.5? The lines you move in the 3.2 template, are still in the same position too in master (in the tt template file).
Comment 2 Owen Leonard 2011-07-06 12:10:18 UTC
Here is the corresponding change in master (Bug 6367): http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd985ea4e2bd80f9f0628f4cb4dd7c0
Comment 3 Marcel de Rooy 2011-07-06 12:14:38 UTC
(In reply to comment #2)
> Here is the corresponding change in master (Bug 6367):
> http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd985ea4e2bd80f9f0628f4cb4dd7c0

Thanks for responding. I looked at acqui template. So I understand now that the same change should still be applied there (just as in cataloguing) ..
Comment 4 Ian Walls 2011-07-08 19:53:36 UTC
Patch does not apply to either current HEAD nor 3.2.x branch.  Is this a backport only, and if so, to which version?
Comment 5 Julian Maurice 2011-07-22 07:50:02 UTC
It applies fine for me on branch 3.2.x.

git am -iu3 Patches/dl/0001-Corrects-the-popup-menu-links-in-the-z3950-search-re.patch
Commit Body is:
--------------------------
Corrects the popup menu links in the z3950 search results.

The popup menu's options didn't link to the correct breedingid.
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Corrects the popup menu links in the z3950 search results.
Using index info to reconstruct a base tree...
<stdin>:16: trailing whitespace.
            
<stdin>:39: trailing whitespace.
            
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl

And it works.
Comment 6 Frédérick Capovilla 2011-07-25 13:03:09 UTC
Additionnal information : This patch was created on version 3.02.03.001 .

Sorry for the inconvenience.
Comment 7 Chris Cormack 2011-07-31 23:57:31 UTC
With 3.2.x ended, does this need to be reformatted for 3.4.x/master or is the bug not existent there?
Comment 8 Magnus Enger 2011-08-04 06:40:58 UTC
I just tested this with Cataloging > Z39.50 Search on current master, and the problem is still there. All the popups use the "importid" of the record at the bottom of the list.
Comment 9 Owen Leonard 2011-08-11 18:55:11 UTC
Magnus, it's working for me on master. See this video and watch the status bar showing the import id for each link:

http://www.screencast.com/t/ZlUtyLemDJtb

The links in each row match.
Comment 10 Chris Cormack 2013-01-01 22:31:57 UTC
This needs a full rewrite if it is still needed
Comment 11 Katrin Fischer 2013-01-03 07:07:32 UTC
I think this has been fixed a longer time ago, please reopen if I am mistaken.