Bug 6570 - Unlabeled box on funds form
Summary: Unlabeled box on funds form
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/admin/aqbudgets.pl?op=ad...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 17:36 UTC by Nicole C. Engard
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
textbox without label (49.35 KB, image/png)
2011-07-08 17:36 UTC, Nicole C. Engard
Details
Proposed fix (1.20 KB, patch)
2011-07-13 14:25 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-07-08 17:36:54 UTC
Created attachment 4610 [details]
textbox without label

See attached. There is a big textarea that doesn't have a label that is appearing on the form.
Comment 1 Owen Leonard 2011-07-13 13:46:35 UTC
Interestingly, the problem happens in Firefox 5, Safari 5, and the latest Chrome but not in Firefox 3.6.
Comment 2 Owen Leonard 2011-07-13 14:25:08 UTC
Created attachment 4624 [details] [review]
Proposed fix

The cause was a missing </select>, an error which wasn't
picked up by the HTML validator. Firefox 3.6 didn't have
a problem with it, but newer browsers must be changing
the way they accommodate markup errors.
Comment 3 Ian Walls 2011-07-14 12:00:28 UTC
Easy fix to read, validates, fixes issue, marking as Passed QA
Comment 4 Chris Cormack 2011-07-14 21:52:30 UTC
Pushed please test