Line 20 of internet-tmpl/prog/en-GB/circ-toolbar.inc AND line 20 of internet-tmpl/prog/en-GB/members-toolbar.inc read: var is_confirmed = window.confirm(_('Are you sure you want to renew this user\\'s registration?')); It should read: var is_confirmed = window.confirm(_('Are you sure you want to renew this user\'s registration?')); This bug causes the buttons on the patron's 'circ' and 'details' pages to not display properly. Further, as a result, the 'Delete' button will not work. I'm not sure if this error appears in the templates for other languages.
Confirmed in a freshly-processed installation of en-GB and en-NZ translations.
*** Bug 7109 has been marked as a duplicate of this bug. ***
I also confirm this bug ib en-NZ
The same issue is found in moremember.tt.
Using double quites instead of single quotes is currently the most used fix for this. It prevents translators from using double quotes in translations, but single quotes are more often used in a lot of languages. In the past I had problems with escaping in Pootle - \n was changed to \\n (double escaped) automatically. So I think not using escaping is safer.
Created attachment 13831 [details] [review] Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl.
I'm not really clear on how translations get from template -> pootle -> misc/translator/po -- there may be a step in testing necessary for that (like, grabbing the new .po from translate.koha-community.org or somesuch).
Created attachment 13983 [details] [review] [SIGNED-OFF] Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes reported problem.
QA Comments: I did not test this patch, but it does not break anything and is in agreement with the result of the discussion of Bug 6574. Marked as Passed QA. Jared, this patch will be in conflict with Bug 6261. So I advice you to apply the patch of Bug 6261 before this one.
Created attachment 14270 [details] [review] Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes reported problem. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I believe this patch is unnecessary now that bug 6261 has been pushed. Could you please confirm that?
Created attachment 14304 [details] [review] Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl.
This last patch is based on the work of 6261, which was just pushed. It'll need a new signoff.
Created attachment 14317 [details] [review] [SIGNED-OFF] Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA Comment: Same as comment 9 Marked as Passed QA.
Created attachment 14560 [details] [review] Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.2 and 3.8.9