Bug 6586 - Calendar showing the wrong event type when editing
Summary: Calendar showing the wrong event type when editing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-13 20:39 UTC by Nicole C. Engard
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
calendar showing diff info on right and left (the right is right) (63.88 KB, image/png)
2011-07-13 20:39 UTC, Nicole C. Engard
Details
Proposed fix (5.36 KB, patch)
2011-07-14 13:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot of the revised interface (33.47 KB, image/png)
2011-07-14 13:40 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-07-13 20:39:09 UTC
Created attachment 4625 [details]
calendar showing diff info on right and left (the right is right)

When you click to edit an event on the calendar it has the wrong event type on the left. See the image.
Comment 1 Owen Leonard 2011-07-14 13:37:56 UTC
Created attachment 4630 [details] [review]
Proposed fix

This bug must have been present for a while. There wasn't proper
handling of repeating yearly holidays when it came to the label.

To be clear, I believe this bug only affected holidays which repeat
yearly on the same date.

Instead of correcting the label to match the existing scheme I
added a new color code and label so that there are now two styles
for yearly and weekly repeating holdiays. This makes it more
clear what kind of repeating holiday you're looking at (rather
than having one color code for both).

After applying this patch, new and existing holidays which
repeat yearly on the same day should be color-coded orange and have
a 'Holiday repeating yearly' label. Weekly holidays are now
labeled 'Holiday repeating weekly.'
Comment 2 Owen Leonard 2011-07-14 13:40:33 UTC
Created attachment 4631 [details]
Screenshot of the revised interface
Comment 3 Ian Walls 2011-07-14 14:45:35 UTC
Template only change, well documented, easy to see that it works.  Marking as Passed QA
Comment 4 Chris Cormack 2011-07-14 21:52:27 UTC
Patch pushed, please test