Bug 6612 - Sort pulldown for messages in alphabetical order
Summary: Sort pulldown for messages in alphabetical order
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/circ/circulation.pl?bor...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 12:24 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
not in order (23.36 KB, image/png)
2011-07-20 12:24 UTC, Nicole C. Engard
Details
Proposed fix (1.63 KB, patch)
2011-07-20 13:17 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-07-20 12:24:26 UTC
Created attachment 4673 [details]
not in order

It would be nice if the pull down menu with the BOR_NOTES on the patron check out screen were in alpha order.
Comment 1 Owen Leonard 2011-07-20 13:03:26 UTC
The values in the menu come straight out of GetAuthorisedValues(), which sorts its results by "category, lib, lib_opac." Rather than trying to re-sort the data in circulation.pl I wonder if we should just change the output in the template to display the note ('lib', the description) itself rather than the authorised_value? The column size in the database is the same (varchar 80) for both authorised_value and lib, so it's not like the description is going to get too big, compared to the authorised_value, to show in the drop-down.
Comment 2 Nicole C. Engard 2011-07-20 13:11:12 UTC
I'm A-OK with that, I would like the description to be longer though since we're using 'description' for a 'note' which I often need more than 80 characters for.  But if we put the description in and truncate it after X characters maybe we can put the code in there too in parens or something if the code is necessary to some libraries to identify the notes.

Nicole
Comment 3 Owen Leonard 2011-07-20 13:17:13 UTC
Created attachment 4674 [details] [review]
Proposed fix

This patch implements only the display of the description on the assumption that at a maximum of 80 characters it will never need to be truncated. I'd be happy to modify this if others feel that libraries will miss being able to see the authorised_value.
Comment 4 Ian Walls 2011-07-20 13:30:10 UTC
Template only change, easy to read, marking as Passed QA
Comment 5 Chris Cormack 2011-07-20 21:50:56 UTC
Pushed, please test