Bug 6614 - CSV Basket Export gives blank lines
Summary: CSV Basket Export gives blank lines
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P1 - high major (vote)
Assignee: Bugs List
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 15:41 UTC by Ian Walls
Modified: 2015-12-03 22:00 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch (979 bytes, patch)
2011-07-26 20:39 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2011-07-20 15:41:41 UTC
If an order note contains "\n", that line will not print in the exported CSV basket, because "\n" is an invalid character to Text::CSV->combine().
Comment 1 Nicole C. Engard 2011-07-26 20:39:30 UTC Comment hidden (obsolete)
Comment 2 Ian Walls 2011-07-26 20:42:53 UTC
Single line patch, with note, in a subroutine used in a single place.  Marking as Passed QA; feel free to contest if uncomfortable.
Comment 3 Chris Cormack 2011-07-26 20:57:56 UTC
Pushed please test
Comment 4 Colin Campbell 2011-07-27 10:29:10 UTC
"\n" is not a invalid character if you create the object with binary set. As the object is created at present there is also a problem with characters other than 7-bit ascii see the Important Note in perldoc Text::CSV
Comment 5 Katrin Fischer 2011-11-02 21:25:27 UTC
Hm, reading Colin's comment this seems to need more work. I am removing the 'patch sent' status.
Comment 6 Jared Camins-Esakov 2012-02-12 20:11:16 UTC
Comment on attachment 4744 [details] [review]
patch

Already pushed.
Comment 7 Jonathan Druart 2015-03-27 09:53:38 UTC
Patch pushed and the changes are removed by bug 7302.
Please open a new bug report if the issue still exists.