Bug 6621 - Javascript error in cloning subfields
Summary: Javascript error in cloning subfields
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Justin @ Prosentient
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 05:20 UTC by Justin @ Prosentient
Modified: 2012-10-26 00:51 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
makes var buttonDotOnClick a String for IE7 (1.16 KB, text/plain)
2011-07-22 05:35 UTC, Justin @ Prosentient 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin @ Prosentient 2011-07-22 05:20:36 UTC 
While cataloguing using IE7, the clone subfields button doesn't do anything. Delete subfields does, strangely enough. This is most likely a JavaScript error. (This problem can be worked around by switching to IE8.)
Comment 1 Justin @ Prosentient 2011-07-22 05:35:22 UTC 
Created attachment 4709 [details]
makes var buttonDotOnClick a String for IE7
Comment 2 Marcel de Rooy 2011-08-04 11:07:59 UTC 
(In reply to comment #1)
> Created attachment 4709 [details]
> makes var buttonDotOnClick a String for IE7

I have a question about:
var buttonDotOnClick = String(link.getAttribute('onclick'));

Where did you define link in the Clonefield function?
Why do you call String? Is it necessary to recover from a null? This may indeed be browser dependent.
I tested your patch in IE8, but have to say that there are more JS errors while doing that. Our users are running staff in Firefox for that reason.
Comment 3 Owen Leonard 2011-08-24 16:22:05 UTC 
I'm marking this Failed QA because of the questions raised above. Let's re-evaluate after that.
Comment 4 Jared Camins-Esakov 2012-02-10 14:58:21 UTC 
Because this problem is with 3.2 which is no longer supported, and IE7 which is several versions out of date, I don't think anyone is going to pick this up again. If you are able to reproduce the problem with a current version of Koha and would like to submit a revised patch that addresses Marcel's concerns, please reopen the bug.