label-item-search.pl uses its own routine to generate pagination links. It should use the pagination_bar function and the standard markup so that the pagination links look and work the same as on other Koha pages.
Created attachment 75858 [details] [review] Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly.
Created attachment 76748 [details] [review] Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 76750 [details] [review] Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Stumbled on bug 21050 while testing this.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Not a real bug, I choose not to push to 17.11.x
Reverted from 18.05.x for 18.05.03, I missed a dependency chain here.. :'(.