Would be nice if in the calendar I could say we're closed the 1st-3rd. Right now that's not an option with repeatable holidays or unique holidays.
Christophe made something for this. It's still to be tested though, maybe christophe you could format your patch, attach it here, and Nicole will test it (and propose better wordings as you did, because I saw some words that seemed odd ... even to me...)
(In reply to comment #1) > Christophe made something for this. It's still to be tested though, maybe > christophe you could format your patch, attach it here, and Nicole will test it > (and propose better wordings as you did, because I saw some words that seemed > odd ... even to me...) Ok Paul, I'll do that. But some stuff in holidays.tmpl need to be rewrited in holidays.tt, this WE I think...
Created attachment 6537 [details] [review] Allow to select a range between 2 dates for holiday 2 new choices : Holidays on a range Holidays repeated yearly on a range you just have to type in the "To Date : " field the end of the range. The syspref "dateformat" changes of course the order of input boxes. It's a basic feature, I think it could be improve... With "delete on a range"... First step, but usefull I hope
Could we use the datepicker widget for the "To Date" instead of the three separate inputs?
Owen, it would be better of course... My patch is very basic, so, no in this state. But I'll try to code that. Thx for comment.
Entering unique and repeating date ranges works for me, but I agree with Owen that a date picker would be more consistent and easier to manage. I noticed that the 'today' button on the calendar is broken.
Created attachment 6569 [details] [review] Add a datepicker for "to date" in a range selection I hope this one is better. I have tryed to keep the code light. Thx for testing.
Created attachment 6586 [details] [review] Signed-off patch
This looks good. A couple of possible future improvements: - Prevent the user from choosing a date which falls before the "From Date" - Only show the "To Date" if one of the "range" options is selected
It's right Owen, I have thought about a hidding of "To Date:" when the "range" options is not selected. But not about a check on the "to date" integrity. The best would be with a "grey-zone" calandar, but I am not sure with this one if I am able to do that, anyway at least a warning message would be usefull. So, thx Owen, Katrin, I'll try to code the suggestions of Owen.
QA comment : * code OK * works fine * perlcritic OK * prove xt/author/translatable-templates.t OK passed QA Patch pushed, please test
*** Bug 7681 has been marked as a duplicate of this bug. ***
This was incorporated into 3.6.x prior to 3.6.4.